spanner: handle unrecognized database default isolation level in PG SHOW statements
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 65/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- google-cloud, java, postgresql
- Domain
- backend-api-design, database
Research direction
This issue follows up on #14904 and names DatabaseMetadata and DatabaseClient as the change points. Read that pull request and its linked review comment, then trace how PostgreSQL isolation level SHOW statements handle UNRECOGNIZED values. Done when those statements return the raw database default and an older client no longer fails with FAILED_PRECONDITION for an unrecognized level.
Written by the indexing model from the issue text.
Description
Follow-up to #14904, based on this review comment.
If the database's default_transaction_isolation holds a value this client doesn't recognize, the PostgreSQL isolation level SHOW statements fail with FAILED_PRECONDITION. An older client should keep working with a database that uses a newer default isolation level.
Proposal:
- Store the raw
default_transaction_isolationvalue inDatabaseMetadataand expose it throughDatabaseClient. - Return that value from the
SHOWstatements when the level isUNRECOGNIZED, instead of throwing.
- Dominant language
- Java
- Stars
- 2.1k
- Forks
- 1.2k
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 192
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from googleapis/google-cloud-java
-
[java-core] Timestamp.of(java.sql.Timestamp) is one second late for a time less than a second before the epochPossibly taken @Vcode2407 claimed this 4 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
googleapis/google-cloud-java#14636 ·
Maintainers usually reply within 1 day
-
[java-firestore] UserDataConverter encodes a pre-epoch Date with negative nanos, so the write is refusedPossibly taken @wu-hui claimed this 23 days ago. Openpriority: p2 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
googleapis/google-cloud-java#14635 · 1 assignee ·
Maintainers usually reply within 1 day
-
[java-firestore] UserDataConverter throws IndexOutOfBoundsException on an empty __binary__ valuePossibly taken @wu-hui claimed this 23 days ago. Openpriority: p2 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
googleapis/google-cloud-java#14634 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
[java-firestore] CustomClassMapper.convertBigDecimal calls .abs() on Double, unintentionally flipping negative values to positiveMay be free again @wu-hui claimed this 45 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
googleapis/google-cloud-java#14533 · 1 assignee ·
Maintainers usually reply within 1 day
-
Github CI failing when trying to install xmllintPossibly taken @blakeli0 claimed this 81 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
googleapis/google-cloud-java#14132 · 1 comment ·
Maintainers usually reply within 1 day
All issues in googleapis/google-cloud-java
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug:unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
UniversalMediaServer/UniversalMediaServer#6473 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
ClickHouse/clickhouse-java#3349 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
StarRocks/starrocks#83246 · 1 comment ·
Maintainers usually reply within 1 day