gapic_metadata.proto should be updated automatically

Open
#13,289 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
50/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
java
Domain
build-system

Research direction

Start with sdk-platform-java/gapic-generator-java/pom.xml, where the fixed googleapis commitish is referenced, and compare it with gapic/metadata/gapic_metadata.proto and the java-common-protos location. Determine how the repository can sync the proto automatically without downloading from GitHub during builds. Done means updates no longer require manual commitish changes and the build remains hermetic.

Written by the indexing model from the issue text.

Description

priority: p3 type: feature request

gapic_metadata.proto currently downloads from a fixed commitish of googleapis.

There are two main issues with this approach

  • This caused toil that we have to manually update the commitish whenever we need to use new features from the proto.
  • Always downloading from Github makes the build non-hermetic and could cause flaky build if Github is not responsive.

Possible solution: We may want to use automations to sync it from googleapis to java-common-protos.

Dominant language
Java
Stars
2.1k
Forks
1.2k
Avg merge
2d 14h
Merged PRs (30d)
192

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from googleapis/google-cloud-java

All issues in googleapis/google-cloud-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.