generated quickstarts shoudl use const& when iterating through lists

Open
#16,394 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
developer-experience

Research direction

Locate the generator or templates that produce the quickstarts, then search for loops matching for (auto e : ListFoo()). Update the generated iteration pattern consistently and run the repository's relevant generation or validation checks; done means generated quickstarts use auto const& for list elements.

Written by the indexing model from the issue text.

Description

cpp: generator type: cleanup

Instead of for (auto e : ListFoo()) use for (auto const& e : ListFoo()).

Dominant language
C++
Stars
659
Forks
463
Avg merge
1d 2h
Merged PRs (30d)
89

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from googleapis/google-cloud-cpp

All issues in googleapis/google-cloud-cpp

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.