If a service is deprecated and its the last version fo the library, we need to fully deprecate it

Open
  • Is something wrong?
#3,898 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
nodejs, typescript
Domain
build-system

Research direction

Start with src/generator/download.ts around the existing logic for deleting missing service clients, then review PR 3890 and the linked automation example. Define the last-version case so the entire library is removed automatically, including the commits needed to avoid stalling the PR.

Written by the indexing model from the issue text.

Description

type: process

see https://github.com/googleapis/google-api-nodejs-client/pull/3890
basically lifesciences was fully deprecate it, and we have logic to delete missing service clients: https://github.com/googleapis/google-api-nodejs-client/blob/main/src/generator/download.ts#L153 but in the PR above, it happened to be the only version, so once we deleted it, we ended up having to delete the whole library. So we should have logic to fully delete it automatically so it doesn't stall the PR.

basically need to automate these commits: https://screenshot.googleplex.com/BTsMYtG9ypXm6Sd

Dominant language
TypeScript
Stars
12.3k
Forks
2k
Avg merge
3d 10h
Merged PRs (30d)
9

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from googleapis/google-api-nodejs-client

All issues in googleapis/google-api-nodejs-client

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.