Apiary updates have become difficult & painful

Open
#3,715 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
git, github, github-actions, nodejs, typescript
Domain
ci-cd, devops, release

Research direction

Start with the update-apis.yaml workflow and its action log to identify the Unprocessable Entity failures and Node 18-related behavior. Then inspect the generated PR merge failures and the differing squash versus rebase requirements for release-please and generator PRs. Done means the Apiary update workflow completes reliably and the required merge strategy is clear and workable.

Written by the indexing model from the issue text.

Description

size: m type: process
  1. Recently, apiary updates have started failing, see our action log. Some of these were due to Node 18 see (fixes #3685, #3686), but others seem to mysteriously fail with "Unprocessable Entity".
  2. The action often will result in a PR that looks fine, but when you go to merge it says: "This branch cannot be rebased". However it will not suggest the normal conflict-resolution suggestions, and so far the only way I have solved this is by manually-merging.
  3. Release PRs must be merged via a Squash strategy for release-please, but generator PRs need to be merged via Rebase. Github just recommends the latest way of merging, and there are no restrictions/rules to this back-and-forth strategy changing.
Dominant language
TypeScript
Stars
12.3k
Forks
2k
Avg merge
3d 10h
Merged PRs (30d)
9

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from googleapis/google-api-nodejs-client

All issues in googleapis/google-api-nodejs-client

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.