Sheets `clear` operation breaks with HTTP/2

Open
#3,602 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
node.js, typescript
Domain
api, networking

Research direction

Start with the linked public gist and reproduce the Sheets clear operation with HTTP/2 enabled, then compare it with the working HTTP/1.1 behavior. Trace the client path used by the gist and verify the fix by observing a successful clear response and the specified sheet actually being cleared.

Written by the indexing model from the issue text.

Description

Please make sure you have searched for information in the following guides.
A screenshot that you have tested with "Try this API".

N/A

Link to the code that reproduces this issue. A link to a public Github Repository or gist with a minimal reproduction.

https://gist.github.com/neil-lobo/e632aae751fe7aec8bbc29a42c585015

A step-by-step description of how to reproduce the issue, based on the linked reproduction.
  1. Save credentials.json file with correct access to sheet to root of project
  2. Replace [sheet ID] with accessible sheet
  3. Run script
  4. Observe output
  5. Turn off http2
  6. Observe output
A clear and concise description of what the bug is, and what you expected to happen.

Using the http2 option, the clear operation does not work. I assume https://github.com/googleapis/google-api-nodejs-client/issues/1801#issuecomment-524921412 is no longer the case since there is an explicit option to enable http2 now.

Referring to the gist, the expected output is

finish get 200
finish clear 200
<end of program>

however the output is

finish get 200
<end of program>

Disabling http2 produces the correct output. Note that this is not simply a response issue, the operation itself does not reflect in the specified sheet.

A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **

Breaks usage

Dominant language
TypeScript
Stars
12.3k
Forks
2k
Avg merge
3d 10h
Merged PRs (30d)
9

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from googleapis/google-api-nodejs-client

All issues in googleapis/google-api-nodejs-client

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.