[anneal] Align root-manifest validation across the updater and standalone auditor

Open
#3,944 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python, rust

Research direction

Read ci/update_root_manifest.py around lines 32–55 and trusted/audit/src/lib.rs around lines 1032–1057 to compare accepted checksum markers. Check the manifest absence review thread and identify which entry points require locked inputs; the hosted workflow already requires the file. Done means updater and auditor accept the same manifest formats and required entry points fail when the manifest is absent.

Written by the indexing model from the issue text.

Description

The root-manifest updater preserves both GNU checksum mode markers,
while the Rust auditor recognizes only the two-space text-mode
separator. A binary-mode entry accepted by the updater can therefore
fail when the standalone auditor reads the same manifest.

The standalone auditor also accepts an absent manifest. Decide which
entry points require the locked inputs and make absence fail for those
entry points. The hosted workflow already requires the file.

Manifest absence review thread

This is a follow-up to importing the auditor at the exact source
revision. The updater and auditor should agree on the accepted
manifest format.

Updater at c131b32 · Auditor at c131b32 · Migration review thread

Authored by an AI agent acting on joshlf's behalf.

Dominant language
Rust
Stars
2.6k
Forks
194
Avg merge
18h 15m
Merged PRs (30d)
14

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from google/zerocopy

All issues in google/zerocopy

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.