`ingest_log` sends local wall-clock time labelled as UTC by default, and raises TypeError for timezone-aware `log_entry_time`
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- python
- Domain
- backend-api-design
Research direction
Start by reading ingest_log() and its timestamp handling, including the defaults, ordering check, and formatting described in the issue. Compare its behavior with get_alerts, which the issue cites as handling naive and aware datetimes. Update the UTC handling for defaults and timezone-aware inputs, then verify defaults and ordering with mocked transport in UTC and non-UTC timezones.
Written by the indexing model from the issue text.
Description
Summary
ingest_log() (and therefore secops log ingest in the CLI, which never passes timestamps) builds its default log_entry_time / collection_time from datetime.now(), which is a naive local time, and then formats it with a literal Z suffix:
now = datetime.now()
...
log_entry_time_str = log_entry_time.strftime("%Y-%m-%dT%H:%M:%S.%fZ")
On any machine whose local timezone is not UTC, every ingested log gets timestamps shifted by the local UTC offset. In addition, passing a timezone-aware log_entry_time while leaving collection_time at its default raises TypeError: can't compare offset-naive and offset-aware datetimes, independent of the local timezone.
The Chronicle logs.import reference defines both fields as RFC 3339 timestamps ("Z-normalized"), and states that collectionTime "Must be after the logEntryTime".
Reproduction (mocked transport, no credentials)
The probe calls ingest_log(client, "OKTA", ["{}"], force_log_type=True) with chronicle_request patched, then compares the log_entry_time that was sent with datetime.now(timezone.utc):
| local TZ | sent log_entry_time vs real UTC now |
|---|---|
UTC |
+0.0 h |
Europe/Berlin |
+1.0 h (in the future) |
America/Los_Angeles |
-8.0 h |
Same probe, ingest_log(..., log_entry_time=datetime.now(timezone.utc) - timedelta(minutes=5)) with no collection_time:
TypeError: can't compare offset-naive and offset-aware datetimes
(raised in all three timezones).
Expected
Defaults should be the current UTC time, and timezone-aware inputs should be converted to UTC before the ordering check and formatting. This is how get_alerts already handles its time range since #35 (naive -> UTC, aware -> astimezone(timezone.utc)).
Environment
secops at ca553eb (main), Python 3.12, macOS arm64. The behaviour comes from datetime.now() semantics, so it is not platform-specific.
Related: the same "format with a literal Z without converting" pattern exists in other modules (for example search_udm / get_stats send 09:00:00Z for a 09:00+01:00 input), but this issue is limited to ingest_log, where it triggers on the default path.
This issue was drafted with Claude Code (claude-opus-5-5); the results above are from the runs described.
- Dominant language
- Python
- Stars
- 94
- Forks
- 49
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from google/secops-wrapper
-
Use warning logging instead of stderr print for HTTP retriesPossibly taken @MatufA claimed this 110 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
google/secops-wrapper#221 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
google/secops-wrapper#213 · 1 comment ·
-
bug(chronicle): nl_search and search_udm drop :udmSearch stats payload and misreport 0 resultsPossibly taken @dandye claimed this 11 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
google/secops-wrapper#227 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
google/secops-wrapper#224 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
google/secops-wrapper#223 · 1 comment ·
All issues in google/secops-wrapper
Similar issues
-
Feature Request
Difficulty 1/5 1-3 hours Newbie friendliness 68/100
spotDL/spotify-downloader#2839 ·
Maintainers usually reply within 1 day
-
Missing license fileOpen
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
ops/setup.py writes ops/hub.json non-atomically (the torn-write class of #219, in the installer)Open
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
mattabate/life-distributable#230 ·
Maintainers usually reply within 1 day
-
enhancement triage:not-checked
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
inventree/InvenTree#13318 · 1 reaction ·
Maintainers usually reply within 1 day
-
agent good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Viox-Development/Artificial-Logic-and-Intelligence-Computation-Engine#251 ·
Maintainers usually reply within 1 day