Label with zero int64 value and no unit get dropped during decoding
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- go
- Domain
- devtools, performance
Research direction
Start at the Parse() function and trace how decoded Sample values populate the NumLabel map. Reproduce a sample containing a zero int64 label with no unit, then verify that the label remains present in the decoded map without changing other label handling.
Written by the indexing model from the issue text.
Description
The current behavior of Parse() function will drop labels with zero int64 value and no unit. For example, a thread id with zero value is meaningful and no unit is applicable. This behavior will cause the thread id information getting dropped for specific samples since the key won't exists in the NumLabel map of decoded Sample.
Should this be fixed to support label with zero int64 value?
- Dominant language
- Go
- Stars
- 9.3k
- Forks
- 682
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 11
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from google/pprof
-
Make comments more discoverable in the web UIPossibly taken @jabrailkhalil claimed this 16 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 45/100
google/pprof#1029 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 74/100
google/pprof#1020 · 1 comment ·
Maintainers usually reply within 1 day
-
pprof cannot locate source code for the list command in common Go setupsPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 48/100
google/pprof#1009 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 42/100
google/pprof#992 · 4 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
google/pprof#914 · 6 comments ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 81/100
apache/rocketmq-dashboard#6895 ·
Maintainers usually reply within 3 days
-
Difficulty 1/5 Under an hour Newbie friendliness 87/100
777genius/agent-notifications#490 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
devantler-tech/ksail#7836 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
keyxmakerx/Chronicle#1469 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day