Integration tests on Apple Silicon attempt to run under Rosetta and fail
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- electron, node.js, typescript
- Domain
- desktop, testing-qa, tooling
Research direction
In extensions/ql-vscode, start with run-integration-tests.ts and the npm run integration entry point; then inspect the referenced vscode-test download.ts behavior. Reproduce on an M1 Mac and compare the downloaded Electron binary with the ARM-native path used by the Run and Debug launch configuration. Done means the command launches an ARM-native VS Code without Rosetta and the integration tests pass.
Written by the indexing model from the issue text.
Description
Describe the bug
Running npm run integration from the command line on an M1 Mac leads to the following error:
> vscode-codeql@1.5.9 integration
> node ./out/vscode-tests/run-integration-tests.js no-workspace,minimal-workspace
Found .vscode-test/vscode-1.63.2. Skipping download.
Running integration tests in these directories: no-workspace,minimal-workspace
Next integration test dir: no-workspace
Launch args: --disable-extensions,--disable-gpu
rosetta error: /var/db/oah/279281325309952_279281325309952/79a831ad051c57eb341ad61bf19eea2efece2baf38aaf9eb68316bb0af278da6/Electron.aot: attachment of code signature supplement failed: 1
Exit code: null
Done
Unexpected exception while running tests: SIGTRAP
Explanation:
- The
run-integration-tests.tstest harness downloads a stable copy of VS Code to execute the tests in. - On Apple Silicon, this downloads an x86 VS Code / Electron binary, even if there is an ARM-native or universal VS Code binary installed.
% file .vscode-test/vscode-1.63.2/Visual Studio Code.app/Contents/MacOS/Electron
.vscode-test/vscode-1.63.2/Visual Studio Code.app/Contents/MacOS/Electron:: Mach-O 64-bit executable x86_64
- I suspect this behaviour originates from
vscode-test, specifically https://github.com/microsoft/vscode-test/blob/fd0e599cd8e096f58f226509c6b76c68f502e926/lib/download.ts#L50, because it only acceptsdarwinas the download platform, without allowing a choice between x86 or ARM. - This means that the integration tests attempt to run under Rosetta.
- Rosetta fails to launch VS Code due to a code signature mismatch.
- This error doesn't happen when running the integration tests from the
Run and DebugUI. This is because the UI test launcher uses the tasks defined inlaunch.json, which start VS Code directly without going throughrun-integration-tests.ts, and use the same VS Code binary as the parent instance (which will be ARM native if you installed it on M1).
Version
VS Code 1.63.2
CodeQL for VS Code 1.5.9
To reproduce
- Clone repo on an M1 Mac.
cd extensions/ql-vscode && npm install && npm run integration- Observe error.
- Choose
Launch Integration Testsfrom theRun and Debugview in the UI. - Observe no error.
Expected behavior
npm run integration should download and launch an ARM-native VS Code binary, without using Rosetta, and the tests should pass.
Additional context
Observed by @angelapwen and diagnosed in internal discussion.
- Dominant language
- TypeScript
- Stars
- 539
- Forks
- 240
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 37
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/vscode-codeql
-
bug VSCode
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
github/vscode-codeql#4471 · 1 comment ·
-
bug enhancement VSCode
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
github/vscode-codeql#592 · 2 comments ·
-
enhancement VSCode
Difficulty 3/5 1-2 days Newbie friendliness 55/100
github/vscode-codeql#4432 · 1 comment ·
-
bug VSCode
Difficulty 3/5 1-2 days Newbie friendliness 52/100
github/vscode-codeql#4356 ·
-
bug VSCode
Difficulty 3/5 1-2 days Newbie friendliness 64/100
github/vscode-codeql#4339 · 1 comment ·
All issues in github/vscode-codeql
Similar issues
-
blocklist removal
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
MetaMask/eth-phishing-detect#296544 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
pastelsky/bundlephobia#1122 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
category/development priority/P2 scope/file-operations scope/testing type/enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Enatega Customer and Rider app: Add-ons price is not visible to customer after order is placed. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100