Integration tests on Apple Silicon attempt to run under Rosetta and fail
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 48/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Estancado
- Stack tecnológico
- electron, node.js, typescript
- Área
- desktop, testing-qa, tooling
Línea de trabajo
En extensions/ql-vscode, empieza por run-integration-tests.ts y el punto de entrada npm run integration; después inspecciona el comportamiento de download.ts de vscode-test al que se hace referencia. Reproduce el problema en un M1 Mac y compara el binario de Electron descargado con la ruta ARM-native utilizada por la configuración de lanzamiento Run and Debug. Se considera terminado cuando el comando inicia un VS Code ARM-native sin Rosetta y las pruebas de integración pasan.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Describe the bug
Running npm run integration from the command line on an M1 Mac leads to the following error:
> vscode-codeql@1.5.9 integration
> node ./out/vscode-tests/run-integration-tests.js no-workspace,minimal-workspace
Found .vscode-test/vscode-1.63.2. Skipping download.
Running integration tests in these directories: no-workspace,minimal-workspace
Next integration test dir: no-workspace
Launch args: --disable-extensions,--disable-gpu
rosetta error: /var/db/oah/279281325309952_279281325309952/79a831ad051c57eb341ad61bf19eea2efece2baf38aaf9eb68316bb0af278da6/Electron.aot: attachment of code signature supplement failed: 1
Exit code: null
Done
Unexpected exception while running tests: SIGTRAP
Explanation:
- The
run-integration-tests.tstest harness downloads a stable copy of VS Code to execute the tests in. - On Apple Silicon, this downloads an x86 VS Code / Electron binary, even if there is an ARM-native or universal VS Code binary installed.
% file .vscode-test/vscode-1.63.2/Visual Studio Code.app/Contents/MacOS/Electron
.vscode-test/vscode-1.63.2/Visual Studio Code.app/Contents/MacOS/Electron:: Mach-O 64-bit executable x86_64
- I suspect this behaviour originates from
vscode-test, specifically https://github.com/microsoft/vscode-test/blob/fd0e599cd8e096f58f226509c6b76c68f502e926/lib/download.ts#L50, because it only acceptsdarwinas the download platform, without allowing a choice between x86 or ARM. - This means that the integration tests attempt to run under Rosetta.
- Rosetta fails to launch VS Code due to a code signature mismatch.
- This error doesn't happen when running the integration tests from the
Run and DebugUI. This is because the UI test launcher uses the tasks defined inlaunch.json, which start VS Code directly without going throughrun-integration-tests.ts, and use the same VS Code binary as the parent instance (which will be ARM native if you installed it on M1).
Version
VS Code 1.63.2
CodeQL for VS Code 1.5.9
To reproduce
- Clone repo on an M1 Mac.
cd extensions/ql-vscode && npm install && npm run integration- Observe error.
- Choose
Launch Integration Testsfrom theRun and Debugview in the UI. - Observe no error.
Expected behavior
npm run integration should download and launch an ARM-native VS Code binary, without using Rosetta, and the tests should pass.
Additional context
Observed by @angelapwen and diagnosed in internal discussion.
- Lenguaje dominante
- TypeScript
- Estrellas
- 539
- Forks
- 240
- Merge medio
- 2 d 18 h
- PR fusionados (30 d)
- 37
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de github/vscode-codeql
-
bug VSCode
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
github/vscode-codeql#4471 · 1 comentario ·
-
bug enhancement VSCode
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
github/vscode-codeql#592 · 2 comentarios ·
-
enhancement VSCode
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
github/vscode-codeql#4432 · 1 comentario ·
-
bug VSCode
Dificultad 3/5 1-2 días Aptitud para principiantes 52/100
github/vscode-codeql#4356 ·
-
bug VSCode
Dificultad 3/5 1-2 días Aptitud para principiantes 64/100
github/vscode-codeql#4339 · 1 comentario ·
Todos los issues de github/vscode-codeql
Issues similares
-
blocklist removal
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
MetaMask/eth-phishing-detect#296544 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
pastelsky/bundlephobia#1122 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
category/development priority/P2 scope/file-operations scope/testing type/enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Enatega Customer and Rider app: Add-ons price is not visible to customer after order is placed. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100