gh stack rebase --continue doesn't report new conflicts hit while resuming a multi-commit branch rebase
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 72/100
Research direction
Start in cmd/rebase.go at continueRebase and compare its in-progress path with printConflictDetailsWithContinue. Then trace git.RebaseContinue in internal/git/gitops.go and tryAutoResolveRebase in internal/git/git.go; reproduce the multi-commit conflict flow with gh stack rebase --continue. Done means a later conflict reports the current Conflicted files block instead of only the generic error.
Written by the indexing model from the issue text.
Description
Summary
gh stack rebase --continue only prints Conflicted files: listing for first conflict encountered when cascading one stacked branch onto another. If resolving that conflict and continuing causes git to hit a second conflict on a later commit within the same branch's replay, the tool does not report what files are now conflicted and just returns a generic wrapped error.
This can make it look like there's only one conflicted file when there are actually more. You can only see the other conflicts by manually running git status.
Steps to reproduce
- Create a stack with a branch containing at least two commits and at least two files, where:
- Commit A modifies
file1.txtso that there's a conflict with the (rebased) parent branch. - Commit B later modifies
file2.txtso that it also conflicts with the parent branch, independently of commit A.
- Commit A modifies
- Rebase the stack
- The tool stops on commit A's conflict and correctly prints:
Conflicted files: C file1.tsx (lines N–M) - Resolve
file1.txt, stage it, rungh stack rebase --continueagain. - Git internally applies commit B next, which conflicts on
file2.txt.
Expected behavior
Step 5 should print the same kind of Conflicted files: block, listing file2.txt with its conflict line numbers, like step 3 did for file1.txt.
Actual behavior
Step 5 prints a generic error:
rebase continue failed — resolve remaining conflicts and try again: exit status 1
No indication of which file(s) are now conflicted. The only way to discover where the new conflict is is running git status manually.
Proposed solution / notes
I'll be honest, not familiar with Go so this "solution" is mostly Claude. I did double check that it looks at least mostly right to me. Figured it might be helpful.
Traced this to
cmd/rebase.goandinternal/git/git.go:
printConflictDetails()/printConflictDetailsWithContinue()(cmd/rebase.go:545) is the function that formats theConflicted files:block with per-file conflict-marker line numbers (viagit.FindConflictMarkers). It's only called from the branch-to-branch cascade logic, atcmd/rebase.go:259and:435.continueRebase()(cmd/rebase.go:312) has a separate path for resuming an already in-progressgit rebasewithin a single branch's multi-commit replay:This path never callsif git.IsRebaseInProgress() { rebaseOpts := git.RebaseOpts{CommitterDateIsAuthorDate: state.CommitterDateIsAuthorDate} if err := git.RebaseContinue(rebaseOpts); err != nil { return fmt.Errorf("rebase continue failed — resolve remaining conflicts and try again: %w", err) } }printConflictDetails.- Following
RebaseContinue(internal/git/gitops.go:334) intotryAutoResolveRebase(internal/git/git.go:118), the conflicted-files list is actually fetched — just to check whetherrererealready auto-resolved everything — and then discarded on the way out:conflicts, err := ConflictedFiles() if err != nil { return originalErr } if len(conflicts) > 0 { return originalErr // <-- conflicts is right here and gets thrown away }Fix: in
continueRebase, whengit.RebaseContinuereturns an error, callprintConflictDetailsWithContinue(using the still-in-progress rebase's current conflicted files, e.g. by callinggit.ConflictedFiles()again, or by threadingtryAutoResolveRebase's localconflictsslice out through the error) before returning, instead of just wrapping the raw error string. That gives resume-mid-branch conflicts the same reporting as cascade-boundary conflicts.
Environment
ghversion: 2.97.0 (2026-07-31)gh-stackextension:github/gh-stackv0.1.0- OS: macOS Tahoe 26.5.1
- Dominant language
- Go
- Stars
- 1.5k
- Forks
- 73
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 7
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/gh-stack
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
feature request topic: cli - general
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
feature request topic: auto-merge
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
bug topic: docs
Difficulty 1/5 Under an hour Newbie friendliness 68/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
NVIDIA/gpu-operator#2955 ·
-
agentic-workflows
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
kovidgoyal/kitty#10516 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
cisagov/vulnrichment#337 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100