External threat-detection artifact omits retry diagnostics
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
Research direction
Read pkg/workflow/threat_detection_external.go, especially buildUploadDetectionArtifactStep, and compare it with buildUploadDetectionLogStep in pkg/workflow/threat_detection_steps.go. Then inspect the related generated upload path coverage. Done means the external artifact includes detection_harness_retry.json when present, respects the existing redaction conditions, and regression coverage verifies the generated paths.
Written by the indexing model from the issue text.
Description
In gh-aw v1.0.1, the threat-detection artifact upload omits /tmp/gh-aw/threat-detection/detection_harness_retry.json. However, the conclusion job’s usage collector expects that source file and copies it to /tmp/gh-aw/usage/detection/harness_retry.json.
Because detection and conclusion run in separate jobs, any retry diagnostics written to the source path cannot reach the usage artifact without being included in the detection upload.
Evidence
buildUploadDetectionArtifactStepuploads the detection result, execution evidence, and usage files, but omits the retry-diagnostics file.collect_usage_artifact_files.shexplicitly expects and copies that file.- The alternative
buildUploadDetectionLogStepalready includes it.
Steps to reproduce
- Use gh-aw v1.0.1.
- Compile a workflow.
- Inspect the generated Upload threat detection artifact step.
- Compare its paths with the conclusion job’s Upload usage artifact paths.
The usage upload lists usage/detection/harness_retry.json, but the detection upload does not transfer its source file.
Expected behavior
Include detection_harness_retry.json in the external detection artifact when present, preserving the existing redaction conditions.
Impact
Retry diagnostics can be lost between jobs, reducing troubleshooting visibility.
Suggested fix
Add the source path to buildUploadDetectionArtifactStep and regression coverage for its inclusion in the generated upload paths.
- Dominant language
- Go
- Stars
- 5.5k
- Forks
- 606
- Avg merge
- 4h 35m
- Merged PRs (30d)
- 807
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/gh-aw
-
automation doc-healer documentation
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
agent-research
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
automation cookie
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
agentic-workflows automation aw-essential cookie
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
automated-analysis code-quality cookie refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
github/gh-aw#73088 · 2 comments ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
microcks/microcks-cli#608 · 1 comment ·
Maintainers usually reply within 1 day
-
bug from-studio
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
esengine/DeepSeek-Reasonix#14868 ·
Maintainers usually reply within 1 day
-
Install notes print "Camunda REST API: https://" without a host when global.host is setPossibly taken @irisfield claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
camunda/camunda-platform-helm#7790 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
project-zot/zot#4636 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
keyxmakerx/Chronicle#1911 ·
Maintainers usually reply within 1 day