shellcheck SC2154 for `gh_aw_exit_code` in the agent execution step
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
Research direction
Read pkg/workflow/engine_helpers.go, focusing on buildAgentExecutionExitCodeTrapWithCleanup. Check how its generated trap affects shellcheck's handling of gh_aw_exit_code; verify the generated script for an agent job with shellcheck 0.11.0. Done means the generated script no longer reports SC2154.
Written by the indexing model from the issue text.
Description
Summary
shellcheck 0.11.0 reports SC2154 (gh_aw_exit_code is referenced but not assigned) in Execute GitHub Copilot CLI in every compiled lock file with an agent job. The variable is assigned inside the single-quoted trap '...' EXIT string from buildAgentExecutionExitCodeTrapWithCleanup (pkg/workflow/engine_helpers.go), which shellcheck does not parse.
Version
gh-aw v0.89.21; shellcheck 0.11.0.
Expected
The generated script is shellcheck-clean. For example, move the trap body into a function, or declare gh_aw_exit_code before the trap.
- Dominant language
- Go
- Stars
- 5.3k
- Forks
- 568
- Avg merge
- 8h 50m
- Merged PRs (30d)
- 721
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/gh-aw
-
ai-inspected
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
automation code-quality cookie improvement quick-win task-mining
Difficulty 2/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
cookie maintenance step-naming
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
agentic-workflows automation code-quality cookie documentation improvement quick-win task-mining
Difficulty 2/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
automated-analysis code-quality cookie testing
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
golang/go#82033 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 90/100
FootprintAI/Containarium#2338 ·
Maintainers usually reply within 1 day
-
[Bug]: core doesn't build standalone on dev since a17068054 (go-mp3 require dropped, go.sum pruned)Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
SagerNet/sing-openvpn#11 ·
-
priority: P3 type: devops
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
jiegui2025/hwspec#57 ·
Maintainers usually reply within 1 day