[Duplicate Code] Share the Cloud Hypervisor network-plan fixture between launch and config tests

Start with the duplicated fixtures in src/cloud-hypervisor/manager-launch.test.ts and src/cloud-hypervisor/vm-config-builder.test.ts, then inspect the surrounding test utilities. Add the shared createTestNetworkPlan() helper in src/cloud-hypervisor/manager.test-utils.ts and update both tests to use it. Done means the topology is defined once and both test suites continue to use the expected network-interface data.

Duplicate Code Opportunity

Summary

• Pattern: The same Cloud Hypervisor network-plan fixture is inlined in two tests instead of being shared through a helper.
• Locations: src/cloud-hypervisor/manager-launch.test.ts:17-40, src/cloud-hypervisor/vm-config-builder.test.ts:7-30
• Impact: 24 duplicated lines in a hot test area. Updates to the default topology, guest addresses, or interface metadata must be made in two places.

Evidence

A. src/cloud-hypervisor/manager-launch.test.ts:17-40

const args = buildSupervisorBootArgs({
  runId: 'run',
  resourceToken: '000000000000',
  namespaceName: 'ns',
  netnsPath: '/var/run/netns/ns',
  nftTableName: 'table',
  hostForwardRuleComment: 'awf:awf_vm_0123456789ab',
  infrastructureBridge: 'awfbr0',
  hostVethName: 'host',
  namespaceVethName: 'namespace',
  tapName: 'tap',
  infrastructureIp: '172.30.0.20',
  infrastructureCidr: '172.30.0.0/24',
  hostGatewayIp: '172.30.0.1',
  guestSubnet: '100.64.0.0/30',
  guestIp: '100.64.0.2',
  guestGatewayIp: '100.64.0.1',
  guestPrefixLength: 30,
  guestMac: '02:00:00:00:00:01',
  tapOwnerUid: 1000,
  tapOwnerGid: 1000,
  tapVnetHdr: true,
  allowedEndpoints: [],
  networkInterface: { iface_id: 'eth0', host_dev_name: 'tap' },
}, guestConfig());

B. src/cloud-hypervisor/vm-config-builder.test.ts:7-30

return {
  runId: 'run',
  resourceToken: '000000000000',
  namespaceName: 'ns',
  netnsPath: '/var/run/netns/ns',
  nftTableName: 'table',
  hostForwardRuleComment: 'awf:awf_vm_0123456789ab',
  infrastructureBridge: 'awfbr0',
  hostVethName: 'host',
  namespaceVethName: 'namespace',
  tapName: 'tap',
  infrastructureIp: '172.30.0.20',
  infrastructureCidr: '172.30.0.0/24',
  hostGatewayIp: '172.30.0.1',
  guestSubnet: '100.64.0.0/30',
  guestIp: '100.64.0.2',
  guestGatewayIp: '100.64.0.1',
  guestPrefixLength: 30,
  guestMac: '02:00:00:00:00:01',
  tapOwnerUid: 1000,
  tapOwnerGid: 1000,
  tapVnetHdr: true,
  allowedEndpoints: [],
  networkInterface: { iface_id: 'eth0', host_dev_name: 'tap', guest_mac: '02:00:00:00:00:01' },
};

Suggested Refactoring

Extract a shared createTestNetworkPlan() helper or fixture in src/cloud-hypervisor/manager.test-utils.ts and reuse it from both tests. That keeps the canonical Cloud Hypervisor topology in one place.

Affected Files

• src/cloud-hypervisor/manager-launch.test.ts — lines 17-40
• src/cloud-hypervisor/vm-config-builder.test.ts — lines 7-30

Effort Estimate

Low

Detected by Duplicate Code Detector workflow. Run date: 2026-09-24

Generated by Duplicate Code Detector · copilot · gpt50mini · 9.48 AIC · ⊞ 21K · ◷

• expires on Oct 24, 2026, 9:43 PM UTC