Feedback: A broken action.lock file causes it to be ignored

Open
#125 4 comments 1 reaction 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
58/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
github-actions, go
Domain
ci-cd, security

Research direction

Start by reproducing the behavior with the broken .github/workflows/actions.lock file in the linked actions-semver-checker commit and review workflow run 34647263399. Trace how gh-actions-lock validates or consumes malformed lockfiles, then add coverage for this case. Done means a broken lockfile is detected and the workflow fails instead of silently ignoring it.

Written by the indexing model from the issue text.

Description

area:policy feedback

I was surprised dependabot was able to suddenly update my actions without workflows failing, turned out I had somehow pushed a broken action lock file:

https://github.com/jessehouwing/actions-semver-checker/blob/7de219d45de803f9febd8e3fd564cb55e0e30f5f/.github/workflows/actions.lock

I'd expect this to fail when a workflow runs, but it just runs without ANY issues.

https://github.com/jessehouwing/actions-semver-checker/actions/runs/34647263399

Dominant language
Go
Stars
253
Forks
15
Avg merge
19h 30m
Merged PRs (30d)
60

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github/gh-actions-lock

All issues in github/gh-actions-lock

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.