Assigning PRs to merger doesn't work when they're auto-merged

Open
#2,137 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
github-actions, python
Domain
ci-cd, devops

Research direction

Start with .github/update-release-branch.py at lines 163-168 and inspect example PR #2110 to understand how assignment is derived for auto-merged pull requests. Confirm the intended assignee behavior for this case; done means auto-merged PRs are assigned according to that rule rather than incorrectly to the merger.

Written by the indexing model from the issue text.

Description

A bunch of [@jsoref's] PRs are assigned to the people who merged them. It feels like the automation hasn't contemplated that PRs would be written by people who can't/won't be the people who will click the "merge" button.

This is intentional:
https://github.com/github/codeql-action/blob/bc64d12bb9f349435efba65d373bac054665b85f/.github/update-release-branch.py#L163-L168

More interesting is that this approach seems to break when enabling auto-merge as can be seen here:
(merged by @angelapwen but PR is from @jsoref)

#2110 (@jsoref)

Originally posted by @intrigus-lgtm in https://github.com/github/codeql-action/issues/2131#issuecomment-1942529486

Dominant language
TypeScript
Stars
1.6k
Forks
493
Avg merge
1d 13h
Merged PRs (30d)
44

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github/codeql-action

All issues in github/codeql-action

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.