Switching accounts shows failures on inactive sessions

Open
#4,057 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Active
Domain
desktop

Research direction

Start by reproducing the account switch on Windows with inactive sessions for already-read or merged pull requests that still show notification bubbles. The work is done when switching accounts no longer changes those closed PR sessions to "interrupted" states.

Written by the indexing model from the issue text.

Description

triage
Short summary

see title

Affected version or release

v1.1.22

Installation context

Windows

What happened?

I switched the user on a new session to work with the right account, and then all my active sessions (blue notifiication icons) are showing "interupted" states:

Image
Steps to reproduce

No response

Expected behavior

Leave my closed PR sessions alone

Additional context

I think these session still had notification bubbles on them (I never grasped why that keeps on happening, the session was read, and the PR's where already merged), which I think causes this issue.

I expected this was also fixed after #3753 was fixed.

Dominant language
No language data
Stars
2.1k
Forks
157
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github/app

All issues in github/app

Similar issues

More Desktop Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.