Add the changed values to the comment that notifies the maintainer about an improvement
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 58/100
Research direction
Find the code that generates the bot comment for improvement suggestions, then trace how it reads the changed advisory JSON. Update the comment behavior so changed fields show their old and new values, and verify that range changes are described accurately without treating removed last-known version data as deletion.
Written by the indexing model from the issue text.
Description
When someone suggests an improvement, the bot comments on the pull request and tags the maintainer. The comment does not say what changed, so the maintainer has to read the diff of the JSON file.
For a range change that diff is easy to misread. The events in ranges stay the same. The only line that changes is database_specific.last_known_affected_version_range, which the form deletes once the range and the fixed event agree. So the change looks like someone deleted version data. That is what happened in #9713 and #9714, where I widened the affected range of two cryptography advisories. Both the maintainer and the automated review read the diff as deleting version data.
It would help if the bot comment listed the fields that changed, with the old and the new value, for example Affected versions: >= 42.0.0, <= 48.0.0 -> >= 42.0.0, < 49.0.0.
- Dominant language
- No language data
- Stars
- 2.5k
- Forks
- 772
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 48
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/advisory-database
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
github/advisory-database#9255 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
github/advisory-database#9164 · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
github/advisory-database#8994 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
github/advisory-database#8898 · 4 comments · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
github/advisory-database#8841 ·
All issues in github/advisory-database
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
punkpeye/mcp-remote#369 ·
-
Mend: dependency security vulnerability untriaged
Difficulty 1/5 Under an hour Newbie friendliness 86/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
cisagov/vulnrichment#337 ·
-
bug DUP Reservations
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
bcgov/reserve-rec-public#896 ·