Add the changed values to the comment that notifies the maintainer about an improvement
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 58/100
Línea de trabajo
Find the code that generates the bot comment for improvement suggestions, then trace how it reads the changed advisory JSON. Update the comment behavior so changed fields show their old and new values, and verify that range changes are described accurately without treating removed last-known version data as deletion.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
When someone suggests an improvement, the bot comments on the pull request and tags the maintainer. The comment does not say what changed, so the maintainer has to read the diff of the JSON file.
For a range change that diff is easy to misread. The events in ranges stay the same. The only line that changes is database_specific.last_known_affected_version_range, which the form deletes once the range and the fixed event agree. So the change looks like someone deleted version data. That is what happened in #9713 and #9714, where I widened the affected range of two cryptography advisories. Both the maintainer and the automated review read the diff as deleting version data.
It would help if the bot comment listed the fields that changed, with the old and the new value, for example Affected versions: >= 42.0.0, <= 48.0.0 -> >= 42.0.0, < 49.0.0.
- Lenguaje dominante
- Sin datos de lenguaje
- Estrellas
- 2.5k
- Forks
- 772
- Merge medio
- 3 d 15 h
- PR fusionados (30 d)
- 46
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de github/advisory-database
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
github/advisory-database#9255 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
github/advisory-database#9164 · 1 reacción ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
github/advisory-database#8994 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
github/advisory-database#8898 · 4 comentarios · 1 reacción ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
github/advisory-database#8841 ·
Todos los issues de github/advisory-database
Issues similares
-
blocklist removal
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
MetaMask/eth-phishing-detect#296544 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Azure/azure-functions-docker#1257 ·
-
area:proxy bug security severity:low track:open-source
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
bug server
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
bytedance/UI-TARS-desktop#2009 · 1 comentario ·