Cannot add teams to repo.yml

Open
#809 8 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
github, javascript
Domain
api, backend

Research direction

Start with the .github/repos/Prequal.yml example and reproduce applying an existing team or a team already associated with the repository in the self-hosted probot/settings app. Trace the team-add entry point and confirm that applying the configuration completes without the GitHub Enterprise 422 error.

Written by the indexing model from the issue text.

Description

bug

Problem Description

What's Happening

We're managing repository-level team permissions using individual repo YAML files (e.g., Mobile.yml, Web.yml, infra.yml) under the .github/repos directory. We do not maintain any team configurations in settings.yml.

The intent is to explicitly grant certain teams (like all engineering teams) permissions to deploy to non-prod environments. For example:

# .github/repos/Prequal.yml

repository:
  name: Prequal
  teams:
    - name: SRE
      permission: maintain
    - name: "Engineering Members"
      permission: push

However, when applying these settings, we encounter the following error:

Error adding team: 422

API response:

{
  "message": "Validation Failed",
  "errors": [
    {
      "resource": "Team",
      "code": "unprocessable",
      "field": "data",
      "message": "Name must be unique for this org"
    }
  ],
  "documentation_url": "https://docs.github.com/rest/teams/teams#create-a-team",
  "status": "422"
}

This seems to happen when the team already exists or is already associated with the repository.

Expected Behavior

We want to know if there's a way to skip adding a team if it already exists or is already associated with the repository, to avoid the 422 error. Ideally, the settings app should be idempotent in this case.


Context

  • GitHub App: Self-hosted instance of probot/settings
  • Platform: GitHub Enterprise (EMU)
  • Versions:
    • probot/settings: [please insert version]
    • GitHub Enterprise: [please insert version]

Dominant language
JavaScript
Stars
942
Forks
238
PR merge metrics
No merged PRs in 30d

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github-community-projects/safe-settings

All issues in github-community-projects/safe-settings

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.