app_installations reports an error on every repo or suborg change when the plugin is not configured
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 64/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
- Domain
- backend
Research direction
Start in lib/settings.js, where syncSelectedRepos calls syncAppInstallations whenever hasChangedConfigs is true, and find the point where the enterprise-authenticated client is required. Add a guard so the plugin returns early when no app_installations config exists at the org, suborg, or repo level, even if repos changed. Done means a PR or push that touches a repo file with no enterprise installation and no app_installations config concludes successfully, and the existing config-present path still works.
Written by the indexing model from the issue text.
Description
Version: 3.0.0
syncSelectedRepos always calls syncAppInstallations with the changed repos (lib/settings.js). Because hasChangedConfigs is true, the "No app_installations config found, skipping" early return never applies. Without an enterprise installation, every PR or push that touches a repo file fails with:
Cannot sync app installations: enterprise-authenticated client not available for '<enterprise>'.
This happens even when no app_installations config exists at any level. Settings are still applied, but the check run concludes failure.
Expected: skip the plugin when no app_installations is configured at the org, suborg, or repo level, even when repos changed.
Workaround: add disable_plugins: [app_installations] to deployment-settings.yml.
- Dominant language
- JavaScript
- Stars
- 924
- Forks
- 227
- Avg merge
- 6h 8m
- Merged PRs (30d)
- 15
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github-community-projects/safe-settings
-
Repos transferred into the org are not synced (no repository.transferred handler)Possibly taken @breymander claimed this 3 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
github-community-projects/safe-settings#1107 · 1 comment ·
Maintainers usually reply within 1 day
-
Dry run only inspects the first 30 changed files (pulls.listFiles is not paginated)Possibly taken @3rwww1 claimed this 25 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github-community-projects/safe-settings#1080 ·
Maintainers usually reply within 1 day
-
PR comment diff table shows an empty vertical scrollbar due to malformed <tr> markupMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
github-community-projects/safe-settings#1077 ·
Maintainers usually reply within 1 day
-
Bug Report: environment and repo variables API calls don't paginate, failing with more than 10 itemsPossibly taken @cdav claimed this 78 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
github-community-projects/safe-settings#1040 ·
Maintainers usually reply within 1 day
-
Teams plugin: PR comment/nop diff shows phantom additions+deletions for unchanged teams due to name vs. slug mismatchPossibly taken @StephHope claimed this 56 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
github-community-projects/safe-settings#1033 ·
Maintainers usually reply within 1 day
All issues in github-community-projects/safe-settings
Similar issues
-
[Website] Catalog: unknown sort value and mixed-case technology in the URL break the filtersPossibly taken @barbierajput378-pixel claimed this today. Openarea/website framework/jekyll help wanted language/css language/javascript language/markdown
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
meshery/meshery.io#3088 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
firecrawl/firecrawl-mcp-server#548 ·
Maintainers usually reply within 1 day
-
Area:WebGL p5.js 2.0+
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
processing/p5.js#9302 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
documentation good first issue hacktoberfest
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
wassim-azi/agy-powerline#47 ·
Maintainers usually reply within 1 day