Migrate route param gating to `dataCollection.userInfo`

Open
#5,998 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
58/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Quiet
Tech stack
react-native, typescript
Domain
mobile

Research direction

Start in packages/core/src/js/tracing/reactnavigation.ts at the route parameter handling around line 488, then read the existing route parameter tests in packages/core/test/tracing/reactnavigation.test.ts. Update the gating behavior to use resolved dataCollection.userInfo, and run the React Navigation tracing tests to confirm dynamic route parameters behave as expected.

Written by the indexing model from the issue text.

Description

Errors React-Native Task

Replace sendDefaultPii check in React Navigation integration with dataCollection.userInfo.

Callsite

  • reactnavigation.ts:488 — dynamic route params (e.g. [id], [...slug]) are only attached to navigation spans when sendDefaultPii is true

Should read from resolved dataCollection.userInfo instead.

References

  • packages/core/src/js/tracing/reactnavigation.ts
  • packages/core/test/tracing/reactnavigation.test.ts — existing tests for route param behavior
Dominant language
TypeScript
Stars
1.8k
Forks
367
Avg merge
1d 6h
Merged PRs (30d)
94

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from getsentry/sentry-react-native

All issues in getsentry/sentry-react-native

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.