Remove `_experiments` replay options compat shim in v9
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- mobile
Research direction
Start by reading the compat shim in packages/core/src/js/integrations/default.ts and the related option definitions in options.ts. Remove the two deprecated _experiments replay options and assess whether initialScope belongs in the same cleanup. Done means the shim and deprecated type definitions are gone, with the v9 deprecation scope resolved.
Written by the indexing model from the issue text.
Description
Summary
The _experiments.replaysSessionSampleRate and _experiments.replaysOnErrorSampleRate options were deprecated in favor of the root-level replaysSessionSampleRate / replaysOnErrorSampleRate options. A compat shim in packages/core/src/js/integrations/default.ts copies the old values to the new location at init time.
The original comment said "Remove in the next major version (v7)", but this was missed in both v7 and v8. Updated to v9 in #5881.
Action for v9
- Remove the compat shim in
default.ts(lines 144-154) - Remove the
_experiments.replaysSessionSampleRateand_experiments.replaysOnErrorSampleRatetype definitions fromoptions.ts - Consider also removing the
initialScopeoption (deprecated since v5, replacement:getGlobalScope()/getIsolationScope())
References
- Dominant language
- TypeScript
- Stars
- 1.8k
- Forks
- 367
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 94
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getsentry/sentry-react-native
-
React-Native Replays Task
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
getsentry/sentry-react-native#6680 · 1 comment ·
-
Improvement React-Native
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
getsentry/sentry-react-native#6143 · 2 comments ·
-
React-Native Task User Feedbacks
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
getsentry/sentry-react-native#5932 · 2 comments ·
-
Good First Issue React-Native Task
Difficulty 1/5 Under an hour Newbie friendliness 65/100
getsentry/sentry-react-native#5771 · 1 comment ·
-
Improvement React-Native
getsentry/sentry-react-native#6723 · 1 comment · 1 assignee ·
All issues in getsentry/sentry-react-native
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100