`getDefaultIntegrations` no longer extends the base set
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- documentation
Research direction
Read packages/cloudflare/src/baseSdk.ts:45, sdk.ts:13, and request.ts:9, then compare the default integration sets and the related history described in the issue. Update the comments so they accurately describe the identical sets and remove any advice that has no effect; confirm the documentation is consistent and no functionality is changed.
Written by the indexing model from the issue text.
Description
packages/cloudflare/src/baseSdk.ts:45 documents that "getDefaultIntegrations in sdk.ts extends this set with the integrations that do depend on Node.js APIs". sdk.ts:13 is:
export function getDefaultIntegrations(options: CloudflareOptions): Integration[] {
return getBaseDefaultIntegrations(options);
}
The two sets are identical. packages/cloudflare/src/request.ts:9 then tells users to "pass defaultIntegrations: getDefaultIntegrations(options) in options to get the full set instead", which is now a no-op.
Work item. Work out whether a nodejs_compat-only integration was dropped or never added. Then either restore it or correct both doc comments. Do not leave advice in the docs that does nothing.
**Prior art **(related history only). No issue, but the cause is clear from the history. getsentry/sentry-javascript#21881 added a separate /nodejs_compat entrypoint with the larger integration set, and getsentry/sentry-javascript#22900 "Make the nodejs_compat entrypoint the default" folded it into the default entrypoint and removed it, closing #18803. The two sets became identical at that point and the doc comments were not updated. This is documentation cleanup, not lost functionality.
- Dominant language
- TypeScript
- Stars
- 8.7k
- Forks
- 1.9k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 521
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getsentry/sentry-javascript
-
Flaky Test React Router Framework Spans Tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
getsentry/sentry-javascript#24348 · 1 comment ·
-
javascript
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
getsentry/sentry-javascript#24200 · 2 comments ·
-
javascript Task
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
getsentry/sentry-javascript#24134 · 1 comment ·
-
Cloudflare Workers javascript Tests
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
getsentry/sentry-javascript#24051 · 1 comment ·
-
Bug Bun javascript
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
getsentry/sentry-javascript#24045 · 1 comment ·
All issues in getsentry/sentry-javascript
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100