[Windows/MSVC] C4267 compiler warning in external/breakpad/src/common/md5.cc

Open Beginner friendly
#4,167 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
cpp
Domain
build-system

Research direction

Start with external/breakpad/src/common/md5.cc, especially the warning at line 74, and inspect the nearby size_t to google_breakpad::u32 addition. Build breakpad_client on Windows with MSVC to reproduce the C4267 warning; done means that warning is gone in the reported build.

Written by the indexing model from the issue text.

Description

Bug Dart
Platform

Flutter Desktop Windows

Obfuscation

Disabled

Debug Info

Enabled

Doctor

• Flutter version 3.47.2 on channel stable
• Engine revision a804b26164
• Dart version 3.13.2
• DevTools version 2.60.0
• Platform android-37.0, build-tools 36.0.0

Other Error Monitoring Solution

No

Other Error Monitoring Solution Name

No response

Version

10.4.0

Steps to Reproduce

When building sentry-native on Windows (x64) with MSVC, breakpad_client produces a C4267 compiler warning in external/breakpad/src/common/md5.cc:

Expected Result

No warning

Actual Result
...\external\breakpad\src\common\md5.cc(74,23): warning C4267: '+=': conversion from 'size_t' to 'google_breakpad::u32', possible loss of data [...\external\breakpad_client.vcxproj]
Are you willing to submit a PR?

None

Dominant language
Dart
Stars
878
Forks
311
Avg merge
3d 5h
Merged PRs (30d)
52

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from getsentry/sentry-dart

All issues in getsentry/sentry-dart

Similar issues

More Dart issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.