Add new attributes to simplify generating span names
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- observability-sre
Research direction
Review the existing span attribute conventions for file, FAAS, middleware, resource, and UI spans, then compare them with the cases listed in issue #87. Done should be a resolved set of accepted attribute names and semantics for the affected span categories.
Written by the indexing model from the issue text.
Description
Right now, it's not convenient to generate a name attribute for some spans. The most flexible case is to be able to create a span name from available attributes, but sometimes the attributes are not there, which makes life harder.
e.g., Imagine the product takes in a span with the op "file.write", and wants to create a name field, which should be "File read". The span name "File read" could be conveniently generated from attributes if the span had an attribute called file.operation (or similar), then the SDK (or product code) could generate the name by concatenating the word "File" and the file.operation attribute.
Here are some cases that would benefit from extra attributes:
-
File spans don't have an attribute to represent the filesystem operation. Possible solution:
file.operationattribute that contains a string like"read" -
FAAS function spans don't have an attribute that represents the FAAS provider. Possible solution:
faas.nameattribute that contains a string like"AWS Lambda". In OTLP this is an attribute on the resource! -
Middleware spans don't have an attribute to represent the name of the middleware. Possible solution:
middleware.nameattribute -
Middleware spans don't have an attribute to represent the name of the framework. Possible solution:
http.frameworkattribute that contains a string like"Django" -
Resource spans don't have an attribute to represent the resource type. Possible solution
resource.typeattribute that contains a string like"img"or"css" -
UI spans don't have an attribute that represents the action type. Possible solution:
ui.action.typeattribute that contains a string like"click"
- Dominant language
- TypeScript
- Stars
- 16
- Forks
- 6
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 63
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getsentry/sentry-conventions
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
getsentry/sentry-conventions#732 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
getsentry/sentry-conventions#731 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
getsentry/sentry-conventions#730 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 50/100
getsentry/sentry-conventions#709 · 1 comment ·
Maintainers usually reply within 1 day
-
Span SpecificationsOpen
Difficulty 5/5 Over a week Newbie friendliness 35/100
getsentry/sentry-conventions#659 · 1 comment ·
Maintainers usually reply within 1 day
All issues in getsentry/sentry-conventions
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
paperclipai/paperclip#17151 ·
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
AgoraIO-Extensions/agent-infra#3159 ·
Maintainers usually reply within 1 day
-
blocklist addition
Difficulty 1/5 Under an hour Newbie friendliness 66/100
MetaMask/eth-phishing-detect#304596 ·
Maintainers usually reply within 1 day
-
friction
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
kentcdodds/kody#4142 ·
-
[Bug] Statistics | Task statistics are always empty on MikroORM with MySQL or SQLitePossibly taken @NdekoCode claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
ever-co/ever-gauzy#11214 ·
Maintainers usually reply within 1 day