Consolidate `http.query` and `url.query`
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- documentation
Research direction
Read the linked url.query and http.query convention models first, comparing their definitions and the leading-question-mark difference. Then inspect the Sentry code search for http.query, since that usage must be fixed before standardization. Done means url.query is the selected convention and http.query is deprecated without leaving the identified Sentry dependency unresolved.
Written by the indexing model from the issue text.
Description
Our url.query (model) and http.query (model) conventions are functionally equivalent. Both contain the URL query string from an HTTP request. The main differences are:
url.queryis defined in OTelhttp.querycontains a leading?
Currently both are active conventions (neither are deprecated). Because url.query is defined in OTel, and I don't think the leading ? is useful, I'd like to standardize on url.query and deprecate http.query.
However, even if we agree to do so, http.query is used in Sentry for performance issue detection so we would need to fix that first.
- Dominant language
- TypeScript
- Stars
- 16
- Forks
- 6
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 63
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getsentry/sentry-conventions
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
getsentry/sentry-conventions#732 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
getsentry/sentry-conventions#731 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
getsentry/sentry-conventions#730 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 50/100
getsentry/sentry-conventions#709 · 1 comment ·
Maintainers usually reply within 1 day
-
Span SpecificationsOpen
Difficulty 5/5 Over a week Newbie friendliness 35/100
getsentry/sentry-conventions#659 · 1 comment ·
Maintainers usually reply within 1 day
All issues in getsentry/sentry-conventions
Similar issues
-
area: repo priority: P2 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
appandflow/stim#4107 · 1 comment ·
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 1-3 hours Newbie friendliness 60/100
lingdojo/kana-dojo#32859 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
github/gh-aw-firewall#10364 ·
Maintainers usually reply within 1 day
-
Merge the duplicate kaffir_corn record into sorghumPossibly taken @Crypto-Shroom claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Crypto-Shroom/Bird-Feed-Calculator#322 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
drizzle-team/drizzle-orm#6552 ·
Maintainers usually reply within 2 days