Patchwork includes full patch in diff, resulting in hash mismatch
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Compare the linked email attachment, Patchwork result, and final glibc commit to reproduce how the full patch enters the diff field. Trace the attachment parsing path and verify that reducing the attachment to its diff lets the commit hook match diff hashes and update patch status reliably.
Written by the indexing model from the issue text.
Description
Example email, its result on patchwork and the final commit:
https://sourceware.org/pipermail/libc-alpha/2020-December/120687.html
https://patchwork.sourceware.org/project/glibc/patch/CAMe9rOoe8m3KXs3CDyhXFZ1eEKBWFV+-v-=LnevR=ZNHoRjw9A@mail.gmail.com/
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=2ee7711bdd7de9dd30073b223ce29d5cd50320f6
It looks like patch sent as an attachment is assumed to be just a diff and gets pasted into the diff field; patchwork should try and reduce the attachment to a diff instead so that when the patch gets committed, the commit hook may reliably match the diff hashes and change patch status.
- Dominant language
- Python
- Stars
- 317
- Forks
- 91
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getpatchwork/patchwork
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
getpatchwork/patchwork#668 ·
-
bug web-ui
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
getpatchwork/patchwork#546 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
getpatchwork/patchwork#664 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
getpatchwork/patchwork#663 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
getpatchwork/patchwork#645 ·
All issues in getpatchwork/patchwork
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
canonical/paas-charm#368 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
tech debt
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
StevenBlack/hosts#3256 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
qualcomm/qai-appbuilder#275 ·