Visual e2e tests wait on map animations
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend, testing-qa
Research direction
Start with the animation timers in useMapViewControls.ts and the MapControl component that the visual e2e tests wait on. Find where the animation duration is set, and check how the visual tests currently wait for the map before each screenshot. Done means the map accepts a zero duration under tests, the visual suite runs without the fixed wait, and the screenshots still pass.
Written by the indexing model from the issue text.
Description
Description
The visual e2e tests spend a fixed amount of time waiting for the map to finish animating before each screenshot. The animations are OpenLayers JS timers in useMapViewControls.ts, so Playwright's animations: 'disabled' has no effect and the tests can't shorten them from the outside.
Each visual run is about 70s per browser, and roughly 10s of that is these waits.
Possible approach:
- Let the map component accept a zero animation duration when running under tests (for example via a prop or a test-only flag), so MapControl can wait only for the map to render.
Ref: https://github.com/getodk/central-frontend/pull/1947#issuecomment-6198229387
- Dominant language
- TypeScript
- Stars
- 38
- Forks
- 24
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getodk/web-forms
-
iOS
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 3/5 Half a day Newbie friendliness 54/100
-
Offline send queueOpenIn Enketo
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
Launch form offlineOpenneeds discussion
Difficulty 5/5 Over a week Newbie friendliness 38/100
All issues in getodk/web-forms
Similar issues
-
area:plugins kind:bug priority:p2 ready
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
Escaped `*` followed by `*` (`\**`) never matchesPossibly taken @bardrop claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 71/100
editorconfig/editorconfig-core-js#172 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
vega/vega-webgpu#40 ·
-
type: bug 🐛
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
puckeditor/puck#1929 ·
Maintainers usually reply within 1 day
-
compression() compresses every response at Brotli quality 11Possibly taken @staylor claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day