Relocate and clean up reset.scss of packages/web-forms

Open
#853 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Quiet
Tech stack
bootstrap, scss, typescript
Domain
frontend, testing

Research direction

Inspect packages/web-forms/reset.scss and the apps/forms location, identifying which rules only override Central's Bootstrap styles. Compare the rendered UI before and after any cleanup, then perform visual regression checks on Android, iPhone, Chrome, Firefox, and Safari. Done means the reset is relocated, obsolete rules are removed safely, and component styles remain unchanged.

Written by the indexing model from the issue text.

Description

front-end

Description

Evaluate the feasibility of cleaning up reset.scss by keeping only what we need and relocating the file to apps/forms.

Some rules in reset.scss were specifically added to override Central's Bootstrap styles. Now that the apps are split, Bootstrap no longer affects Web Forms, meaning some of these defensive styles are obsolete.

The trickiest part will be conducting a highly detailed visual regression test. Because this file establishes the baseline for all styles built over time, we need to be extremely careful that pruning and moving these rules doesn't silently break the UI or alter our component styles.

The test should be completed in:

  • Android
  • IPhone
  • Chrome
  • Firefox
  • Safari
Dominant language
TypeScript
Stars
38
Forks
24
PR merge metrics
No merged PRs in 30d

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from getodk/web-forms

All issues in getodk/web-forms

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.