The select1 with "map" appearance shows "Point saved" when no itemset options loaded

Open
#834 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
64/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
typescript
Domain
frontend

Research direction

Reproduce the issue with the “Select one from map bounds” form and its bounds.geojson attachment, then trace the select1 map appearance and status banner behavior when the GeoJSON features have empty properties. Done means an empty option list no longer produces “Point saved” without a selection, and the behavior is covered by an appropriate test or verified against the reproduction.

Written by the indexing model from the issue text.

Description

Expected Behavior

When the GeoJSON itemset data is malformed (missing the id / title properties used by the form), the form should not claim that a selection has been made. Either no "Point saved" should appear, or the form should surface a clear "options could not be loaded" error so the form author can fix the data.

Observed Behavior

The map renders with no pins, but the status bar reads "Point saved" as if the user had selected something. Nothing is actually selected, the consumer's option lookup matches undefined === undefined against the empty option list, so the UI treats the empty current value as a valid selection.

Reported here.

Reproduction Steps

Form (XML or XLSX file): Select one from map bounds.xml + attachment bounds.geojson (features have empty properties: {}).
https://test.getodk.cloud/projects/649/forms/Select%20one%20from%20map%20bounds/submissions

Steps:

  1. Open the form for a new submission.
  2. Navigate to the select1 appearance="map" question.
  3. Without tapping any pin, observe the map and the status banner.

Environment

  • Browser version:
  • OS:
  • Web Forms version:
Dominant language
TypeScript
Stars
38
Forks
24
PR merge metrics
No merged PRs in 30d

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from getodk/web-forms

All issues in getodk/web-forms

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.