Check for select value and label prevents valid select from repeat patterns

Open
#98 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
java
Domain
testing-qa

Research direction

Start with the linked form and the existing JavaRosa tests for this repeat/select shape, then compare Validate behavior with --skip_validate and Collect. Review changes in pyxform and Validate between July 2023 and February 2025; done means identifying the regression and confirming whether removing the duplicate check restores valid forms without weakening required validation.

Written by the indexing model from the issue text.

Description

Some time between July 2023 and February 2025, this form with a select from repeat stopped passing Validate. When I convert it to XForm with --skip_validate, it works as expected in Collect. We have tests in JavaRosa for this form shape. Was there a change in pyxform? Validate? Could we remove that check since pyxform does that work already?

Dominant language
Java
Stars
14
Forks
32
Avg merge
14h 15m
Merged PRs (30d)
2

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from getodk/validate

All issues in getodk/validate

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.