Skip file type guess or lock accepted file type

Open
#74 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
backend

Research direction

Start with app/main.py around the linked file-type guess and read issue #73 for the proposed xls2xform.convert type parameter. Determine whether the accepted behavior should skip guessing or restrict uploads to XLSX. Done means the selected file-type behavior is implemented and XLS/XLSX parsing is covered by the repository's existing checks.

Written by the indexing model from the issue text.

Description

The file type guess seen here could be skipped since pyxform will try parsing as XLSX first and then try XLS (then concatenated formats - markdown then csv) until one of them parses OK. If a file type is specified to xls2xform.convert (see https://github.com/getodk/pyxform-http/issues/73) then only that type is attempted. Perhaps only accepting XLSX at xlsform online https://getodk.org/xlsform/ could be a way to wean off XLS and therefore allow pyxform to drop the sporadically maintained dependency xlrd.

Dominant language
Shell
Stars
5
Forks
12
PR merge metrics
No merged PRs in 30d

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from getodk/pyxform-http

All issues in getodk/pyxform-http

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.