`timeZone: "client"` throws `RangeError: Invalid time value` when rendering a post path
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- javascript, node.js
Research direction
Read util/lib/date.js, especially getDateTokenValues at line 131 and the getDate branch at line 95, then compare their behavior with docs/configuration/time-zone.md. Reproduce the failure through renderPath for timeZone: "client" and "local"; determine whether path tokens should support client or the documentation should clarify that they do not, and make the chosen behavior consistent.
Written by the indexing model from the issue text.
Description
getDateTokenValues (util/lib/date.js:131) special-cases only "server" and passes
anything else to formatDate. Measured through renderPath:
timeZone |
result |
|---|---|
UTC, Europe/Brussels |
path returned |
client, local |
RangeError: Invalid time value |
client is the first documented value in docs/configuration/time-zone.md, and getDate
has a branch for it (date.js:95). Nothing validates application.timeZone at startup.
Which did you intend — a client branch in getDateTokenValues, or client not applying to
path tokens, making the docs wrong? Happy to PR either.
- Dominant language
- JavaScript
- Stars
- 392
- Forks
- 39
- Avg merge
- 22h 29m
- Merged PRs (30d)
- 25
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getindiekit/indiekit
-
Docs: no path for someone who just wants to try IndiekitPossibly taken @rmdes claimed this 13 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
getindiekit/indiekit#1028 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
getindiekit/indiekit#1030 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
getindiekit/indiekit#1027 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
getindiekit/indiekit#1026 ·
Maintainers usually reply within 1 day
-
plugin-syndicator
Difficulty 4/5 3-5 days Newbie friendliness 48/100
getindiekit/indiekit#1022 · 1 reaction ·
Maintainers usually reply within 1 day
All issues in getindiekit/indiekit
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
scratchfoundation/scratch-editor#754 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 96/100
google/site-kit-wp#14102 ·
Maintainers usually reply within 2 days
-
area:growth priority:P1 type:docs
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
tecnologiasantos/bogoboom#66 ·
Maintainers usually reply within 1 day
-
desktop docs good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
npm/write-file-atomic#245 ·