gazebosim/gz-common

Use UTF16 versions of Windows API functions

Open

#129 opened on Nov 23, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (59 forks)auto 404
help wanted

Repository metrics

Stars
 (28 stars)
PR merge metrics
 (PR metrics pending)

Description

Most of ign-common is using the ASCII versions of Windows API functions. These should be converted to the ones using wchar_t (UTF16) strings. The ASCII API is prone to text encoding problems, whereas the UTF16 API doesn't have an issue.

This would probably also deserve a helper function to convert std::string<char> to std::wstring (std::string<wchar_t>). https://stackoverflow.com/questions/4804298/how-to-convert-wstring-into-string might be a good start for this function, as it really isn't as trivial as one would think.

Contributor guide

Research direction
Replace ASCII Windows API calls with UTF16 equivalents and implement a helper function to convert std::string to std::wstring. Refer to the StackOverflow link for conversion details.
Tech stack
ccpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Windows API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60