Fresh JSX bug? Component children not passed to parent as array
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 52/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start by reproducing the issue with the TestParent component shown in the report, in both an Island and server generated context. Trace how JSX children reach the component and compare them with the workaround that passes an array through the children prop. Done means JSX children arrive as an array that can be handled independently in both contexts.
Written by the indexing model from the issue text.
Description
In standard Preact/Preact, children that are passed to a parent component in jsx style...
<TestParent>
<h1>Child 0</h1>
<p>Child 1</p>
</TestParent>
are identified by the parent as an array (of ComponentChild, I suppose).
In Fresh this expected behaviour breaks. Instead, the children are somehow baked into an single object.
This makes it impossible to handle the child items independently - for example mapping over them to wrap each of them in yet another component, or whatever.
It doesn't seem to matter if used in an Island context or server generated.
I guess this must be concidered a bug.
Here below is a test parent component that I've been using to identify the problem:
export function TestParent(
{ children }: { children?: preact.ComponentChildren },
) {
console.log("Children is array:", Array.isArray(children));
return (
<div>
{children}
</div>
);
}
A workaround is to prepare the children as an array, and pass that as children property value...
export default define.page(function Home(ctx) {
// preparing children as an array
const children = [
<h1>Child 0</h1>,
<p>Child 1</p>,
];
return <TestParent children={children} />;
});
...but that's not always possible.
- Dominant language
- TypeScript
- Stars
- 13.8k
- Forks
- 757
- Avg merge
- 3m
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from freshframework/fresh
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
freshframework/fresh#3920 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
freshframework/fresh#3833 ·
-
feat
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
freshframework/fresh#3803 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 10/100
freshframework/fresh#3918 · 1 comment · 4 reactions ·
-
Tab title doesn't update to <Head> <title> when navigating to a page with another <title>Possibly taken @1AbdullahButt claimed this 7 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 57/100
freshframework/fresh#3916 ·
All issues in freshframework/fresh
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
tintinweb/pi-subagents#459 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
danielmiessler/LifeOS#2830 ·
Maintainers usually reply within 6 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area: client enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#3681 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day