Workspace glob patterns fail in deno-loader/deno-resolver esbuild plugins
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 42/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- deno, typescript
- Domain
- build-system
Research direction
Start by locating Fresh’s deno-loader and deno-resolver esbuild plugins and trace how each resolves workspace members from deno.json. Compare that path with Deno’s collect_member_config_folders implementation in workspace/discovery.rs, which the issue identifies as handling globs. Done when both plugins expand workspace globs and the provided reproduction builds successfully.
Written by the indexing model from the issue text.
Description
Summary
When the root deno.json uses a glob pattern (e.g. "./src/*") in the workspace array, Fresh's build process fails with WorkspaceDiscoverError(ResolveMember(NotFound)). The glob is not expanded and is instead treated as a literal path (/src/*/), causing the error.
This originates from the deno-loader and deno-resolver esbuild plugins used by Fresh — not from Deno core. Deno's own workspace resolution (deno_config crate) handles globs correctly via collect_member_config_folders in workspace/discovery.rs, but the esbuild plugins appear to use a version of deno_config that predates glob support, or a code path that doesn't invoke glob expansion.
Reproduction
From denoland/deno#28906:
- Use a workspace config with globs:
{ "workspace": ["./src/*"] } - Run a Fresh app via
createHandlerfrom the workspace root - Build fails with:
✘ [ERROR] WorkspaceDiscoverError(ResolveMember(NotFound { dir_url: ... /src/*/ })) [plugin deno-loader] ✘ [ERROR] WorkspaceDiscoverError(ResolveMember(NotFound { dir_url: ... /src/*/ })) [plugin deno-resolver]
Workaround: list workspace members explicitly instead of using globs.
Minimal repro repo: https://github.com/StaytunedLLP/open_poc/blob/main/src/deno_workspace_fresh/
Expected behavior
The esbuild plugins should expand workspace glob patterns the same way Deno core does, or use a deno_config version that supports them.
- Dominant language
- TypeScript
- Stars
- 13.8k
- Forks
- 757
- Avg merge
- 3m
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from freshframework/fresh
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
freshframework/fresh#3920 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
freshframework/fresh#3833 ·
-
feat
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
freshframework/fresh#3803 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 10/100
freshframework/fresh#3918 · 1 comment · 4 reactions ·
-
Tab title doesn't update to <Head> <title> when navigating to a page with another <title>Possibly taken @1AbdullahButt claimed this 7 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 57/100
freshframework/fresh#3916 ·
All issues in freshframework/fresh
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
tintinweb/pi-subagents#459 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
danielmiessler/LifeOS#2830 ·
Maintainers usually reply within 6 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area: client enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#3681 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day