Investigat type composition of middlewares
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- deno, typescript
- Domain
- backend, developer-experience
Research direction
Start by reading the linked Hono middleware example and Fresh issue #414, then locate Fresh's middleware and route handler type definitions. Determine whether middleware types can compose so later handlers see variables added by earlier middleware; done means the expected types are available across a middleware chain and covered by type tests. The issue has had no activity for 389 days, so check whether the proposal is still relevant.
Written by the indexing model from the issue text.
Description
A user on discord mentioned that Hono has figured that out: https://discord.com/channels/684898665143206084/991511118524715139/1420356127610110044
It's not clearly documented but here's a minimal example that compiles. Could potentially be improved upon if it was more than a neat type hack.
import { Hono } from "jsr:@hono/[email protected]"; import { createMiddleware } from "jsr:@hono/[email protected]/factory"; const fooMiddleware = createMiddleware<{ Variables: { foo: number; }; }>(async (c, next) => { c.set("foo", 12); await next(); }); const barMiddleware = createMiddleware<{ Variables: { bar: string; }; }>(async (c, next) => { c.set("bar", "bar"); await next(); }); const app = new Hono(); app.get("/", fooMiddleware, barMiddleware, (c) => { console.log(c.var.foo); console.log(c.var.bar); return c.text(""); });I discovered it by chance looking to do dependency injection via this issue
https://github.com/honojs/hono/issues/414
- Dominant language
- TypeScript
- Stars
- 13.8k
- Forks
- 757
- Avg merge
- 3m
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from freshframework/fresh
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
freshframework/fresh#3920 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
freshframework/fresh#3833 ·
-
feat
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
freshframework/fresh#3803 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 10/100
freshframework/fresh#3918 · 1 comment · 4 reactions ·
-
Tab title doesn't update to <Head> <title> when navigating to a page with another <title>Possibly taken @1AbdullahButt claimed this 7 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 57/100
freshframework/fresh#3916 ·
All issues in freshframework/fresh
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
tintinweb/pi-subagents#459 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
danielmiessler/LifeOS#2830 ·
Maintainers usually reply within 6 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area: client enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#3681 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day