Skip the Docker containers for suites too small to gain from them

Ouverte
  • Quelque chose ne va pas ?
#426 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
22/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Active
Stack technique
docker, mysql, php
Domaine
testing-qa

Piste de recherche

The decision lives in utils/behat-parallel.php, which already computes the per-scenario cost used to balance workers; start there and check how the Docker fallback is chosen when WP_CLI_TEST_DOCKER=auto. The Docker image is built from utils/docker/Dockerfile, which #425 covers. Done means a threshold that skips containers for the small packages listed in the issue, a fallback message like the existing ones, and matching timings on the full matrix.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

scope:testing

Part of #394.

Since wp-cli/.github#313, every Linux Behat job runs its scenarios in 4 parallel workers in Docker containers. Large suites gain a lot from it. Small suites pay more than they get back, because every job has a fixed setup cost of about 70 to 80 seconds, whatever its size:

  • 40 to 63 seconds before the first worker starts. Most of this is building the worker image from utils/docker/Dockerfile (see #425 for that part).
  • Another 20 to 30 seconds for starting the containers and database servers, and for removing them again.

In the full-matrix runs of all 29 packages on 2026-11-02, compared with the median of their October runs on main, runner time per Testing run changed as follows:

Packages Before (min) After (min) Change
Large suites 9 3,762 1,893 −50%
Small suites 20 1,734 2,214 +28%

In the job for PHP 8.4, WP latest and MySQL 8.0:

Package Scenarios Behat step Longest worker
maintenance-mode-command 3 71 s 10 s
role-command 5 84 s 14 s
site-health-command 5 87 s 16 s
super-admin-command 5 91 s 20 s
eval-command 21 91 s 13 s
entity-command, for comparison 511 457 s 372 s

Before the change, maintenance-mode-command used 49 runner-minutes per Testing run; now it uses 97.

Proposal: with WP_CLI_TEST_DOCKER=auto, run the scenarios without Docker when their expected cost is too low for the containers to pay off, and report it like the other fallbacks ("... Running the scenarios without Docker."). The expected cost per scenario that utils/behat-parallel.php already computes for balancing the workers can decide this, so the threshold does not depend on scenario counts alone. Below the threshold, parallel workers on the runner itself (#405) are still available. These add only a few seconds, as long as the test user can create the worker databases.

WP_CLI_TEST_DOCKER=1 keeps forcing containers, so that a small suite can still be run in them deliberately.

Measuring: pick the threshold from the per-job numbers above. Then run the full matrix of a few small packages (for example maintenance-mode-command, role-command, eval-command, cron-command) and a few packages near the threshold (for example cache-command, export-command) against the change, and compare runner time and Behat time per job with the runs of 2026-11-02. If #425 lands first, measure against it, as a cheaper image moves the break-even point.

Langage dominant
PHP
Étoiles
42
Forks
28
Merge moyen
18 h 52 min
PR mergées (30 j)
27

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de wp-cli/wp-cli-tests

Toutes les issues de wp-cli/wp-cli-tests

Issues similaires

Plus d'issues PHP

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.