Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

vp run hangs after a failure when a cancelled task's detached descendant holds its IPC connection

Ouverte
  • Quelque chose ne va pas ?
#878 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
48/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
node.js, playwright, rust
Domaine
backend, cli

Piste de recherche

Start with the cancellation path in crates/vt/src/session/execute/spawn.rs and the IPC client drain in crates/vt_server/src/lib.rs, both linked in the issue. Reproduce with the supplied vp run repro setup, then trace how cancellation and open descendant connections affect shutdown. Done means fail-fast exits promptly with a nonzero status while a detached descendant holds the IPC connection; the issue names no tests.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Written by an AI agent (Claude) on behalf of @jasonkuhrt.

When a sibling task fails, vp run kills a cached task's direct child, then keeps running for as long as a detached descendant of that task holds its runner IPC connection. In the repro below, 20 seconds after the failure the task's process was dead, its detached child was alive, and the session was still running. Killing only the detached child let the session exit 1 at once.

We hit this with Playwright: its webServer starts vp dev in a detached process group, so when fail-fast SIGKILLs Playwright, the dev server survives with an open IPC connection and the session hangs until it is killed by hand (locally) or the job times out (CI).

Repro

package.json

{
  "name": "ipc-hang-repro",
  "private": true,
  "type": "module",
  "scripts": {
    "fail": "node repro.cjs fail"
  },
  "devDependencies": {
    "vite-plus": "1.3.0"
  }
}

vite.config.ts

export default {
  run: {
    tasks: {
      repro: {
        command: 'echo done',
        dependsOn: ['fail', 'cached'],
      },
      cached: {
        command: 'node repro.cjs parent',
        cache: { input: ['repro.cjs'], output: [] },
      },
    },
  },
};

repro.cjs

const { spawn } = require('node:child_process');
const fs = require('node:fs');

switch (process.argv[2]) {
  // Fails once the grandchild has connected.
  case 'fail':
    setInterval(() => {
      if (fs.existsSync('ready.json')) {
        console.log('FAIL: IPC connected; exiting 1');
        process.exit(1);
      }
    }, 100);
    break;
  // The cached task: starts a detached child, then idles.
  case 'parent': {
    const child = spawn(process.execPath, [__filename, 'grandchild'], {
      detached: true,
      stdio: 'ignore',
    });
    child.unref();
    setInterval(() => {}, 1000);
    break;
  }
  // Opens a runner IPC connection, as `vp dev` does, and stays alive.
  case 'grandchild': {
    globalThis.client = require(process.env.VP_RUN_NODE_CLIENT_PATH).load();
    globalThis.client.getEnv('PATH');
    fs.writeFileSync(
      'ready.json',
      JSON.stringify({ parent: process.ppid, grandchild: process.pid }),
    );
    setInterval(() => {}, 1000);
    break;
  }
}

Run

bun install   # any package manager
export PATH="$PWD/node_modules/.bin:$PATH"
rm -f ready.json
vp run repro > run.log 2>&1 &
runner=$!
sleep 20
kill -0 "$runner" && echo 'still running after 20s'
kill -KILL "$(node -p 'require("./ready.json").grandchild')"
wait "$runner"; echo "session exit=$?"

Observed

$ node repro.cjs fail ⊘ cache disabled
$ node repro.cjs parent
FAIL: IPC connected; exiting 1
still running after 20s
session exit=1
vp run: 0/1 cache hit (0%), 0/2 successful.

--last-details reports fail exit 1 and cached exit 137.

Expected

Fail-fast finishes promptly with a nonzero status, and the cancelled task's descendants don't keep the session alive.

Cause

At 9ba4cc9 (the commit Vite+ 1.3.0 pins):

Possible fixes

  • On cancellation, end the task's IPC client handlers, or bound the drain.
  • Kill the task's process group or descendants (detached groups escape a group kill).

Related

  • #822: keep going instead of cancelling sibling tasks.
  • #485: on Windows, completion blocked by descendant-held stdio.
  • #396: an earlier browser hang from descendant-held fspy locks.

Environment

macOS 27.0 (26A428), arm64; Vite+ 1.3.0; Node 24.22.1.

Langage dominant
Rust
Étoiles
480
Forks
50
Merge moyen
1 j 3 h
PR mergées (30 j)
62

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de voidzero-dev/vite-task

Toutes les issues de voidzero-dev/vite-task

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.