[Bug]: FLAC copies in the music cache are never cleaned up

Ouverte
#119 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
55/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
rust
Domaine
backend

Piste de recherche

Start at src/api/music.rs:1266, where flac_copy writes the cache keyed by path, size and mtime, and trace what else reads or deletes files under cache/music/. Then find the scan/indexing path to see where track keys are invalidated on change or deletion, since that is where stale copies would be pruned. Done means the cache is bounded by an eviction rule and orphaned copies are removed during scans, with a test covering both.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Other

What happened?

flac_copy writes a FLAC copy of a track to cache/music/ the first time it's asked for (src/api/music.rs:1266), keyed by path, size and mtime. Nothing removes them, including copies of tracks that changed or were deleted, so the cache grows with every lossy-to-lossless request.

Expected behavior

The cache has a size limit or an expiry.

Suggested fix

Evict least recently used copies over a size limit (or older than N days), and remove copies whose key no longer matches a track during scans.

Langage dominant
TypeScript
Étoiles
4
Forks
1
Merge moyen
4 h 49 min
PR mergées (30 j)
5

Préparer son environnement

  • Fournit un Dockerfile ou un fichier Docker Compose
  • Aucun modèle de pull request
  • Aucun guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de tinystream-dev/tinystream

Toutes les issues de tinystream-dev/tinystream

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.