[Bug]: Authenticated images are sent as publicly cacheable and immutable

Ouverte
#107 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
Une demi-journée
Accessibilité débutants
74/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
rust
Domaine
backend, security

Piste de recherche

Start at the header construction in src/api/images.rs around line 16, where Cache-Control: public, max-age=604800, immutable is emitted, and check which image routes sit behind auth so only those switch to private. Read src/api/library.rs for the existing ?v=…&l=… versioning scheme, then apply it to the poster URLs built in src/automation/series.rs, src/automation/import.rs and src/api/automation.rs. Done means authenticated image responses are privately cacheable and the automation/notification URLs change when artwork does; note the report was from code reading, so confirm on a running server if you can.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Other

What happened?

Item art, season posters and stills are only for signed-in users with library access, but are sent with Cache-Control: public, max-age=604800, immutable (src/api/images.rs:16), so a shared cache or proxy may store and serve them to others. Also, the poster URLs built by automation and notifications (/api/images/item/{id}/poster, e.g. in src/automation/series.rs, src/automation/import.rs, src/api/automation.rs) have no ?v=, so after artwork changes browsers keep the old picture for a week.

Expected behavior

Private caching for authenticated images, and URLs that change when the artwork does.

Suggested fix

Use private, max-age=604800, immutable for everything behind auth, and add the same ?v=…&l=… versioning src/api/library.rs uses to the automation/notification URLs.

Langage dominant
TypeScript
Étoiles
4
Forks
1
Merge moyen
4 h 49 min
PR mergées (30 j)
5

Préparer son environnement

  • Fournit un Dockerfile ou un fichier Docker Compose
  • Aucun modèle de pull request
  • Aucun guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de tinystream-dev/tinystream

Toutes les issues de tinystream-dev/tinystream

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.