Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

"Let me think about it for a moment" does not start a thinking hold

Ouverte
  • Quelque chose ne va pas ?
#369 1 commentaire 0 réactions 1 personne assignée Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@PeteChiang1211 y travaille déjà.

Depuis le 19/10/2026.

  • #407 par @PeteChiang1211 — ouverte

Évaluation

Cette issue n'a pas encore été évaluée.

Description

Observed behavior

Since #192, an explicit spoken request for thinking time starts a thinking hold. requests_thinking_time() does not recognize a request that names what the candidate is thinking about and then how long: "Let me think about it for a moment." and "Let me think about that for a minute." both return false, so no hold starts. Each half is recognized on its own: "Let me think about it" and "Let me think for a moment" both return true. The phrasing is the one from #172 with "about it" added.

Expected behavior

A request with "about it", "about this" or "about that" before a duration, such as "Let me think about it for a moment.", holds the floor the same way "Let me think for a moment." does.

Reproduction
  1. On main at 4faffce, add "Let me think about it for a moment." to the first list in explicit_requests_keep_the_floor in tests/unit/agent/turn_taking.rs.
  2. Run cargo test --release explicit_requests_keep_the_floor.
  3. The test fails at tests/unit/agent/turn_taking.rs:40 with "Let me think about it for a moment."
CodeTrial version

codetrial 0.1.0 (4faffce)

Environment

OS: Ubuntu 26.04 on WSL2 (Windows)
Browser: not applicable, reproduced with a unit test
Language: not applicable
Interview loop: not applicable
Problem: not applicable
REACTO or STAR step: not applicable
Reconnect: not applicable

Sanitized evidence
thread 'agent::turn_taking::tests::explicit_requests_keep_the_floor' panicked at src/agent/../../tests/unit/agent/turn_taking.rs:40:9:
Let me think about it for a moment.
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 1087 filtered out

Analysis: is_tail in src/agent/turn_taking.rs:379 accepts the words after a phrase only when they are one entry of TAILS (line 334), or the start of one, plus an optional "please". TAILS lists "about it" and "for a moment" as separate entries, so "about it for a moment" matches neither. "I need to think about this for a second" is missed the same way, through "i need to think" in PHRASES (line 281).

Proposed change: let is_tail take an optional "about it", "about this" or "about that" before one of the existing TAILS, instead of adding every combination to TAILS. The regression test adds the missed requests to the positive list, and adds "Let me think about it for each node" and "Let me think about it for a moment. Okay, I would use a hash map" to the negative list, so an answer that only starts the same way is still not a request. I will open a pull request with this change.

Public data confirmation
  • I removed credentials, session tokens, candidate recordings, and personal interview content from this public report.
Langage dominant
Rust
Étoiles
177
Forks
100
Merge moyen
1 j 9 h
PR mergées (30 j)
151

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de sysprog21/codetrial

Toutes les issues de sysprog21/codetrial

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.