`contract build` can expose an empty wasm to concurrent builds

Ouverte
  • Quelque chose ne va pas ?
#2,804 1 commentaire 0 réactions 1 personne assignée Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@leighmcculloch y travaille déjà.

Depuis le 15/10/2026.

Évaluation

Cette issue n'a pas encore été évaluée.

Description

bug
What version are you using?

28.1.0 (main at d95abbc).

What did you do?

Ran two stellar contract build (or contract deploy/upload auto-build) processes at the same time on the same cargo workspace.

Note that this also happens in the auto_build integration tests and causes builds to fail sometimes. e.g. deploy_workspace_with_package_auto_builds in this run.

What did you expect to see?

Both builds succeed, with each reader seeing either the previous complete wasm or the new complete wasm.

What did you see instead?

The second build fails with ❌ error: unexpected end-of-file (at offset 0x0) after cargo reports Finished. Perhaps writing each rewrite to a temp file in the same directory and renaming it over the target could avoid the empty window while still breaking the deps/ hard link, though there may be other options worth weighing.

Thoughts

After cargo releases its build lock, inject_meta and filter_spec in cmd/soroban-cli/src/commands/contract/build.rs each rewrite the output wasm in place with fs::remove_file followed by fs::write, and fs::write creates an empty file before writing the bytes, so another process reading the same path in that window sees zero bytes. The remove-then-write pattern came from #1896 to break the hard link cargo keeps to deps/ (#1694), and the only step that writes to a temp file and renames into place today is --optimize, while the --out-dir copy uses fs::copy, which is also not atomic.

The file would not exist as a zero length file for a brief period if it was written to a temp directory, or with a random filename in the current directory, then renamed into place after the write is complete. So this is probably the ideal fix.

Langage dominant
Rust
Étoiles
129
Forks
153
Merge moyen
1 j 14 h
PR mergées (30 j)
11

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de stellar/stellar-cli

Toutes les issues de stellar/stellar-cli

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.