[iOS] JS timers fire late by the size of a backward system clock change

Ouverte
#59,782 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 2 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
53/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
ios, objective-c, react-native, typescript
Domaine
backend, mobile

Piste de recherche

Start with packages/react-native/React/CoreModules/RCTTiming.mm, especially the timer target calculations and sleep NSTimer setup at the cited lines; compare how JavaTimerManager uses monotonic time. The issue also identifies ObjCTimerRegistry.mm and RCTInstance.mm as the bridgeless path. Determine how iOS timers should respond to system clock changes while preserving sleep time, then verify both timeout and interval behavior with the supplied device reproducer.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Needs: Author Feedback Needs: Repro Platform: iOS
Description

On iOS, when the system clock steps back by D, every pending setTimeout and setInterval fires D late. A forward step makes them fire up to D early. Android is not affected. The clock steps when automatic time corrects a clock that ran fast, or when the user sets the time by hand.

RCTTiming stores each timer's target as a wall-clock date, [NSDate dateWithTimeIntervalSinceNow:] (RCTTiming.mm:49, and :68 for intervals), and fires it once [NSDate date] reaches that date (:57-63, :246). For a target more than a second away, it pauses the display link and arms a sleep NSTimer for the same date (:311-313, :318-333), so after a backward step the timer is re-armed for D later. Nothing observes clock changes: setup registers only lifecycle and proximity notifications (:139-160). Bridgeless sends setTimeout through ObjCTimerRegistry into the same class (ObjCTimerRegistry.mm:48-61, wired in RCTInstance.mm:311-316). Android's JavaTimerManager sets targets from nanoTime() (JavaTimerManager.kt:183) and compares them with Choreographer frame time (:294-296), so clock steps do not move them.

https://github.com/react/react-native/issues/11732 reported this on a device with RN 0.35 in 2017, where setting the time back one minute delayed a setInterval by about a minute, with the same diagnosis; it was closed for inactivity and locked. main still has the same code.

We found this in Evolu, a local-first sync library. Its connection watchdog and WebSocket reconnect delays are timers, so after the clock steps back by D, a silently dead connection can show as synced for D.

Steps to reproduce
  1. Set Settings > Display & Brightness > Auto-Lock to Never, then run this App.tsx on an iPhone:

    import { useEffect, useState } from "react";
    import { Text, View } from "react-native";
    
    export default function App() {
      const [status, setStatus] = useState("waiting for a 60 s setTimeout");
    
      useEffect(() => {
        const startElapsed = performance.now();
        const startWall = Date.now();
        const id = setTimeout(() => {
          const elapsed = Math.round((performance.now() - startElapsed) / 1000);
          const wall = Math.round((Date.now() - startWall) / 1000);
          setStatus(`fired after ${elapsed} s; Date.now() moved ${wall} s`);
        }, 60_000);
        return () => clearTimeout(id);
      }, []);
    
      return (
        <View
          style={{ flex: 1, alignItems: "center", justifyContent: "center" }}
        >
          <Text>{status}</Text>
        </View>
      );
    }
    
  2. Within 60 s, open Settings > General > Date & Time, turn off Set Automatically, and set the time one hour earlier.

  3. Return to the app once the 60 s have passed.

We haven't run this on a device. From the code above, the text changes only about an hour later, to fired after 3660 s; Date.now() moved 60 s: the timer waits until the wall clock reaches its original target. A smaller step delays it by that step, as #11732 saw with one minute.

Expected: it fires as soon as you return, about 60 s after the start, as on Android. Time the device spends asleep keeps counting, as it does today.

React Native Version

0.88.1

Affected Platforms

Runtime - iOS

Output of npx @react-native-community/cli info
System:
  OS: macOS 26.6.2
  CPU: (10) arm64 Apple M5
  Memory: 239.14 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 24.22.1
    path: /Users/steida/.nvm/versions/node/v24.22.1/bin/node
  Yarn: Not Found
  npm:
    version: 11.19.1
    path: /Users/steida/.nvm/versions/node/v24.22.1/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.16.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 27.2
      - iOS 27.2
      - macOS 27.2
      - tvOS 27.2
      - visionOS 27.2
      - watchOS 27.2
  Android SDK: Not Found
IDEs:
  Android Studio: 2025.3 AI-253.32098.37.2534.15336583
  Xcode:
    version: 27.2/27B52
    path: /usr/bin/xcodebuild
Languages:
  Java: Not Found
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby

(Trimmed after Languages: in our hoisted pnpm workspace the CLI reports the npm packages as Not Found. They are react-native 0.88.1, react 19.3.0 and @react-native-community/cli 20.2.0.)
Stacktrace or Logs
No crash or log. From the code, the app shows: fired after 3660 s; Date.now() moved 60 s.
MANDATORY Reproducer

The App.tsx above is the whole reproducer. It needs a device whose clock can be changed. The source lines in the description show the cause without running it.

Screenshots and Videos

No response

Langage dominant
C++
Étoiles
127k
Forks
25.5k
Merge moyen
3 j 22 h
PR mergées (30 j)
235

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de react/react-native

Toutes les issues de react/react-native

Issues similaires

Plus d'issues C++

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.