Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

asyncio: Windows socket reset during Proactor cleanup skips socket closure and transport detachment

Ouverte
#160,429 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

  • #160600 par @OsmnvAslan — fermée sans fusion

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
70/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
python

Piste de recherche

Start by reading _ProactorBasePipeTransport._call_connection_lost() in Lib/asyncio/proactor_events.py and the related asyncio transport tests. Use the provided mock-based reproducer to check that a shutdown reset does not skip socket closure, server detachment, or completion marking, while exceptions from protocol.connection_lost() and unexpected shutdown failures remain visible. Done means those cleanup steps run for the expected reset and the regression is covered by a test.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

stdlib topic-asyncio type-bug

Bug description

On Windows, _ProactorBasePipeTransport._call_connection_lost() can raise ConnectionResetError: [WinError 10054] from self._sock.shutdown(socket.SHUT_RDWR) while cleaning up a connection. The exception escapes into the event loop's exception handler before the subsequent socket closure, server detachment, and _called_connection_lost = True execute.

This was observed in an active application on CPython 3.14.5 (Windows), producing Exception in callback _ProactorBasePipeTransport._call_connection_lost() errors. The application continued running. The defect is the interrupted cleanup, beyond the unexpected error log: a socket can remain open until later finalization, and transport bookkeeping remains incomplete.

Deterministic reproducer

This standard-library-only example injects the observed socket-shutdown error and calls the unmodified CPython cleanup method. It demonstrates the skipped cleanup without depending on network timing; it does not reproduce the original TCP reset timing. Run it on Windows in a fresh interpreter without an application-installed asyncio patch.

from asyncio.proactor_events import _ProactorBasePipeTransport
from types import SimpleNamespace
from unittest.mock import Mock

reset = ConnectionResetError("connection reset during shutdown")
reset.winerror = 10054
sock = Mock()
sock.shutdown.side_effect = reset
server = Mock()
transport = SimpleNamespace(
    _called_connection_lost=False,
    _protocol=Mock(),
    _sock=sock,
    _server=server,
)

try:
    _ProactorBasePipeTransport._call_connection_lost(transport, None)
except ConnectionResetError:
    print("ConnectionResetError escaped cleanup")

print("socket.close calls:", sock.close.call_count)
print("server detach calls:", server._detach.call_count)
print("cleanup complete:", transport._called_connection_lost)

Observed output on CPython 3.14.5:

ConnectionResetError escaped cleanup
socket.close calls: 0
server detach calls: 0
cleanup complete: False

Expected behavior

An already-reset socket should still be closed and the transport detached and marked complete. Handle the expected reset around the socket shutdown operation, while ensuring remaining cleanup runs. Exceptions from protocol.connection_lost() and unexpected shutdown failures should remain observable; broadly suppressing exceptions around the whole callback would hide unrelated failures.

A potential improvement would prevent noisy error log messages by catching 'reasonable' shutdown failures and logging them via asyncio's debug logger (if debug mode is enabled for that proactor transport's event loop). Either way, shutdown errors should not cause cleanup to be skipped.

CPython versions tested on

CPython 3.14.5, Windows x86-64. Both the application traceback and the deterministic reproducer were observed on this version.

Source inspection, rather than execution on those interpreters, found the same method implementation in releases 3.14.6–3.14.9 and 3.15.0–3.15.1. See the 3.14.5 source and 3.15.1 source.

Related reports

  • The same shutdown traceback appears in a comment on #125981, a closed issue about SSL: APPLICATION_DATA_AFTER_CLOSE_NOTIFY. I could not find a dedicated issue tracking the interrupted Proactor socket cleanup.
  • #149388 concerned WinError 6 from PipeHandle.close() in this callback. That issue was fixed in PipeHandle; this report concerns WinError 10054 from the preceding socket shutdown() call.
Linked PRs
  • gh-160600
Langage dominant
Python
Étoiles
77.8k
Forks
37.7k
Merge moyen
12 h 14 min
PR mergées (30 j)
729

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de python/cpython

Toutes les issues de python/cpython

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.