Native runtime and installer: load the HIP runtime only from System32 or an official SDK by full path

Ouverte
#242 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
cpp

Piste de recherche

Start with init in clean/runtime/device.cpp (around lines 301-335), the single HIP loader that clean/runtime/runtime.cpp (around lines 698-706) calls, then compare it against the probe in clean/installer/src/wg_core/checks.cpp (around lines 151-189, 210-213, 284-300). Read clean/runner/sdk.py from PR #239 for the official-SDK resolution rule to mirror, and note the Windows loader flags available for System32-only and full-path loads. Adding the no-GPU tests (stand-in DLL on PATH, a HIP_PATH folder outside the official root, an accepted official install) and the BUILDING.md HIP SDK sentence is done when no bare-name load remains in either component and the tests prove it.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Problem

PR #239 makes the Python tools and build scripts use only an official AMD HIP SDK (clean/runner/sdk.py). The native
runtime and the installer still have their own HIP runtime lookup, which does not follow that rule:

  • clean/runtime/device.cpp (init, around lines 301-335) on Windows tries, in order: an explicit rocm_dir (any
    folder, or an exact .dll the installer selected), amdhip64_7.dll from System32, then the same bare name through the
    standard DLL search path (which includes PATH), then the newest folder under C:\Program Files\AMD\ROCm, then
    %HIP_PATH%\bin. On Linux it tries rocm_dir/lib/libamdhip64.so, then the bare name libamdhip64.so (the loader's
    search path). clean/runtime/runtime.cpp (around lines 698-706) reaches this loader.
  • clean/installer/src/wg_core/checks.cpp (around lines 151-189, 210-213, 284-300) probes PATH and HIP_PATH
    candidates on its own.

Example: when System32 has no amdhip64_7.dll, a DLL of that name found through PATH is loaded, or HIP_PATH
pointing at a non-official SDK copy is used. The installer probe can select such a copy as well.

These rules predate #239; changing them changes product behaviour, so they were kept out of that PR.

Proposed rule (runtime and installer the same)

  1. System32 first: the AMD driver's own amdhip64_7.dll (LOAD_LIBRARY_SEARCH_SYSTEM32).
  2. Then an official HIP SDK install by full path: C:\Program Files\AMD\ROCm\<version>\bin\amdhip64_7.dll, newest
    compatible version first (Linux: /opt/rocm-<version>/lib or /opt/rocm/lib, by full path).
  3. Never a bare-name search through PATH or the loader's default search path.
  4. HIP_PATH only when it resolves to one of the official installs of step 2 (otherwise ignored, with a note in the log
    that names it by id only, not by path).
  5. An explicit rocm_dir or installer-selected DLL: only when it is System32's copy or inside an official install
    (tests that need another one get an explicit, logged override).
  6. The installer probe (checks.cpp) uses exactly these rules, so it never selects a runtime the runtime would refuse.

Done when

  • device.cpp, runtime.cpp and checks.cpp follow the rule above; no bare-name load remains.
  • Tests (no GPU): with a stand-in DLL on PATH and in a HIP_PATH folder outside the official root, neither is
    loaded or selected; System32 and the official SDK are; HIP_PATH pointing at an official install is accepted.
  • BUILDING.md (HIP SDK paragraph) states that the native runtime and installer follow the same rule.
Langage dominant
C++
Étoiles
12
Forks
2
Merge moyen
3 h 10 min
PR mergées (30 j)
171

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de phantoslayer21/wronggpu

Toutes les issues de phantoslayer21/wronggpu

Issues similaires

Plus d'issues C++

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.