Native runtime and installer: load the HIP runtime only from System32 or an official SDK by full path
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 35/100
- Type d'issue
- Bug
- Clarté
- Clairement spécifiée
- Activité
- Active
- Stack technique
- cpp
- Domaine
- desktop-dev, security
Piste de recherche
Start with init in clean/runtime/device.cpp (around lines 301-335), the single HIP loader that clean/runtime/runtime.cpp (around lines 698-706) calls, then compare it against the probe in clean/installer/src/wg_core/checks.cpp (around lines 151-189, 210-213, 284-300). Read clean/runner/sdk.py from PR #239 for the official-SDK resolution rule to mirror, and note the Windows loader flags available for System32-only and full-path loads. Adding the no-GPU tests (stand-in DLL on PATH, a HIP_PATH folder outside the official root, an accepted official install) and the BUILDING.md HIP SDK sentence is done when no bare-name load remains in either component and the tests prove it.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Problem
PR #239 makes the Python tools and build scripts use only an official AMD HIP SDK (clean/runner/sdk.py). The native
runtime and the installer still have their own HIP runtime lookup, which does not follow that rule:
clean/runtime/device.cpp(init, around lines 301-335) on Windows tries, in order: an explicitrocm_dir(any
folder, or an exact.dllthe installer selected),amdhip64_7.dllfrom System32, then the same bare name through the
standard DLL search path (which includesPATH), then the newest folder underC:\Program Files\AMD\ROCm, then
%HIP_PATH%\bin. On Linux it triesrocm_dir/lib/libamdhip64.so, then the bare namelibamdhip64.so(the loader's
search path).clean/runtime/runtime.cpp(around lines 698-706) reaches this loader.clean/installer/src/wg_core/checks.cpp(around lines 151-189, 210-213, 284-300) probesPATHandHIP_PATH
candidates on its own.
Example: when System32 has no amdhip64_7.dll, a DLL of that name found through PATH is loaded, or HIP_PATH
pointing at a non-official SDK copy is used. The installer probe can select such a copy as well.
These rules predate #239; changing them changes product behaviour, so they were kept out of that PR.
Proposed rule (runtime and installer the same)
- System32 first: the AMD driver's own
amdhip64_7.dll(LOAD_LIBRARY_SEARCH_SYSTEM32). - Then an official HIP SDK install by full path:
C:\Program Files\AMD\ROCm\<version>\bin\amdhip64_7.dll, newest
compatible version first (Linux:/opt/rocm-<version>/libor/opt/rocm/lib, by full path). - Never a bare-name search through
PATHor the loader's default search path. HIP_PATHonly when it resolves to one of the official installs of step 2 (otherwise ignored, with a note in the log
that names it by id only, not by path).- An explicit
rocm_diror installer-selected DLL: only when it is System32's copy or inside an official install
(tests that need another one get an explicit, logged override). - The installer probe (
checks.cpp) uses exactly these rules, so it never selects a runtime the runtime would refuse.
Done when
device.cpp,runtime.cppandchecks.cppfollow the rule above; no bare-name load remains.- Tests (no GPU): with a stand-in DLL on
PATHand in aHIP_PATHfolder outside the official root, neither is
loaded or selected; System32 and the official SDK are;HIP_PATHpointing at an official install is accepted. BUILDING.md(HIP SDK paragraph) states that the native runtime and installer follow the same rule.
- Langage dominant
- C++
- Étoiles
- 12
- Forks
- 2
- Merge moyen
- 3 h 10 min
- PR mergées (30 j)
- 171
Préparer son environnement
- Aucun Dockerfile ni fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de phantoslayer21/wronggpu
-
Difficulté 2/5 1-3 heures Accessibilité débutants 88/100
phantoslayer21/wronggpu#275 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
phantoslayer21/wronggpu#274 ·
Les mainteneurs répondent en général sous 1 jour
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 88/100
phantoslayer21/wronggpu#241 ·
Les mainteneurs répondent en général sous 1 jour
-
bug build
Difficulté 2/5 1-3 heures Accessibilité débutants 74/100
phantoslayer21/wronggpu#234 ·
Les mainteneurs répondent en général sous 1 jour
-
Launcher tests: "an older record: update available" fakes a version newer than the test buildOuvertebug build
Difficulté 2/5 1-3 heures Accessibilité débutants 80/100
phantoslayer21/wronggpu#233 ·
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de phantoslayer21/wronggpu
Issues similaires
-
Difficulté 1/5 1-3 heures Accessibilité débutants 77/100
Les mainteneurs répondent en général sous 1 jour
-
bug good first issue
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
ReyeMe/SaturnRingLib#155 ·
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 62/100
Nheko-Reborn/nheko#2092 ·
-
Difficulté 1/5 1-3 heures Accessibilité débutants 78/100
isocpp/CppCoreGuidelines#2345 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 71/100
ROCm/rocm-libraries#16108 ·
Les mainteneurs répondent en général sous 2 jours