Table - part of tree table node looks clickable but is not
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Accessibilité débutants
- 56/100
- Type d'issue
- Bug
- Clarté
- Plutôt claire
- Activité
- Active
- Stack technique
- react, typescript
- Domaine
- accessibility, frontend
Piste de recherche
Start with the table tree view example at https://www.patternfly.org/components/table#tree-table and compare its click behavior with the checkbox tree view example and the data-view tree table example linked in the issue. The supplied TableTree code shows TreeRowWrapper and Td with treeRow; determine whether the pointer area should trigger the existing row action and whether a basic non-checkbox example is needed. Done when the tree table’s pointer affordance matches its actual clickable area and the expected behavior is documented or demonstrated.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Here's a link to the example - https://www.patternfly.org/components/table#tree-table. There is also an example below that and another in the data-view extension - https://www.patternfly.org/extensions/data-view/table/#tree-table
Right now the .pf-v6-c-table__tree-view-main element that wraps the entire first part of the node row (toggle + checkbox + node text, and all the space around those things) has a cursor pointer, but only the toggle and checkbox are clickable. Clicking the text or area around the toggle/check (including to the left of them on nested rows) doesn't appear to do anything.
If you compare to the checkbox tree view component example, the entire rows in tree view are clickable because on a non-checkbox node, the whole row is wrapped in a <button>, and the whole row on checkbox nodes is wrapped in a <label> pointing to the checkbox.
Should there be parity between the two? cc @andrew-ronaldson
Also should we add a basic/non-checkbox tree table example? I tried removing the checkboxes from the current example and the text field wasn't clickable but I don't know if I did it correctly. Below is the code I used:
import { useState } from 'react';
import { Table, Thead, Tr, Th, Tbody, Td, TreeRowWrapper, TdProps } from '@patternfly/react-table';
import LeafIcon from '@patternfly/react-icons/dist/esm/icons/leaf-icon';
import RhUiFolderFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-folder-fill-icon';
import RhUiFolderOpenFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-folder-open-fill-icon';
interface RepositoriesTreeNode {
name: string;
branches: string;
pullRequests: string;
workspaces: string;
children?: RepositoriesTreeNode[];
}
export const TableTree: React.FunctionComponent = () => {
// In real usage, this data would come from some external source like an API via props.
const data: RepositoriesTreeNode[] = [
{
name: 'Repositories one',
branches: 'Branch one',
pullRequests: 'Pull request one',
workspaces: 'Workplace one',
children: [
{
name: 'Repositories two',
branches: 'Branch two',
pullRequests: 'Pull request two',
workspaces: 'Workplace two',
children: [
{
name: 'Repositories three',
branches: 'Branch three',
pullRequests: 'Pull request three',
workspaces: 'Workplace three'
},
{
name: 'Repositories four',
branches: 'Branch four',
pullRequests: 'Pull request four',
workspaces: 'Workplace four'
}
]
},
{
name: 'Repositories five',
branches: 'Branch five',
pullRequests: 'Pull request five',
workspaces: 'Workplace five'
},
{
name: 'Repositories six',
branches: 'Branch six',
pullRequests: 'Pull request six',
workspaces: 'Workplace six'
}
]
},
{
name: 'Repositories seven',
branches: 'Branch seven',
pullRequests: 'Pull request seven',
workspaces: 'Workplace seven',
children: [
{
name: 'Repositories eight',
branches: 'Branch eight',
pullRequests: 'Pull request eight',
workspaces: 'Workplace eight'
}
]
},
{
name: 'Repositories nine',
branches: 'Branch nine',
pullRequests: 'Pull request nine',
workspaces: 'Workplace nine'
}
];
const columnNames = {
name: 'Repositories',
branches: 'Branches',
prs: 'Pull requests',
workspaces: 'Workspaces'
};
const [expandedNodeNames, setExpandedNodeNames] = useState<string[]>(['Repositories one']);
const [expandedDetailsNodeNames, setExpandedDetailsNodeNames] = useState<string[]>([]);
/**
Recursive function which flattens the data into an array of flattened TreeRowWrapper components
params:
- nodes - array of a single level of tree nodes
- level - number representing how deeply nested the current row is
- posinset - position of the row relative to this row's siblings
- currentRowIndex - position of the row relative to the entire table
- isHidden - defaults to false, true if this row's parent is expanded
*/
const renderRows = (
[node, ...remainingNodes]: RepositoriesTreeNode[],
level = 1,
posinset = 1,
rowIndex = 0,
isHidden = false
): React.ReactNode[] => {
if (!node) {
return [];
}
const isExpanded = expandedNodeNames.includes(node.name);
const isDetailsExpanded = expandedDetailsNodeNames.includes(node.name);
let icon = <LeafIcon />;
if (node.children) {
icon = isExpanded ? <RhUiFolderOpenFillIcon /> : <RhUiFolderFillIcon />;
}
const treeRow: TdProps['treeRow'] = {
onCollapse: () =>
setExpandedNodeNames((prevExpanded) => {
const otherExpandedNodeNames = prevExpanded.filter((name) => name !== node.name);
return isExpanded ? otherExpandedNodeNames : [...otherExpandedNodeNames, node.name];
}),
onToggleRowDetails: () =>
setExpandedDetailsNodeNames((prevDetailsExpanded) => {
const otherDetailsExpandedNodeNames = prevDetailsExpanded.filter((name) => name !== node.name);
return isDetailsExpanded ? otherDetailsExpandedNodeNames : [...otherDetailsExpandedNodeNames, node.name];
}),
rowIndex,
props: {
isExpanded,
isDetailsExpanded,
isHidden,
'aria-level': level,
'aria-posinset': posinset,
'aria-setsize': node.children ? node.children.length : 0,
icon
}
};
const childRows =
node.children && node.children.length
? renderRows(node.children, level + 1, 1, rowIndex + 1, !isExpanded || isHidden)
: [];
return [
<TreeRowWrapper key={node.name} row={{ props: treeRow.props }}>
<Td dataLabel={columnNames.name} treeRow={treeRow}>
{node.name}
</Td>
<Td dataLabel={columnNames.branches}>{node.branches}</Td>
<Td dataLabel={columnNames.prs}>{node.pullRequests}</Td>
<Td dataLabel={columnNames.workspaces}>{node.workspaces}</Td>
</TreeRowWrapper>,
...childRows,
...renderRows(remainingNodes, level, posinset + 1, rowIndex + 1 + childRows.length, isHidden)
];
};
return (
<Table isTreeTable aria-label="Tree table">
<Thead>
<Tr>
<Th width={40}>{columnNames.name}</Th>
<Th>{columnNames.branches}</Th>
<Th>{columnNames.prs}</Th>
<Th>{columnNames.workspaces}</Th>
</Tr>
</Thead>
<Tbody>{renderRows(data)}</Tbody>
</Table>
);
};
Jira Issue: PF-4745
Jira Issue: FELT-4421
- Langage dominant
- TypeScript
- Étoiles
- 859
- Forks
- 395
- Merge moyen
- 3 j 13 h
- PR mergées (30 j)
- 15
Préparer son environnement
- Aucun Dockerfile ni fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de patternfly/patternfly-react
-
fix(table): CollapseColumn uses wrong caret icon for expandable row togglePeut-être pris @redhat-chai-bot l’a pris aujourd’hui. Ouverte
Difficulté 1/5 Moins d'une heure Accessibilité débutants 85/100
patternfly/patternfly-react#12727 ·
Les mainteneurs répondent en général sous 1 jour
-
Bug - PageSidebar - collapsed sidebar is aria-hidden but its navigation links stay in the tab orderPeut-être pris @Sophran-fbj l’a pris il y a 4 jours. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 74/100
patternfly/patternfly-react#12693 ·
Les mainteneurs répondent en général sous 1 jour
-
Bug - Label - Doesn't allow ref forwardingPeut-être pris @tarunvashishth l’a pris il y a 28 jours. OuvertePF Team Stale
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
patternfly/patternfly-react#12651 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
-
Bug - [Menu] - Flyout stays open when hovering a disabled itemPeut-être pris @fallmo l’a pris il y a 64 jours. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
patternfly/patternfly-react#12637 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
-
PF Team Stale
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
patternfly/patternfly-react#12617 · 2 commentaires ·
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de patternfly/patternfly-react
Issues similaires
-
[Site] Active section detection should respect scroll-margin-topPeut-être pris Une pull request liée à cette issue est ouverte ou déjà fusionnée. Ouvertearea/web reproduced type/bug
Difficulté 2/5 1-3 heures Accessibilité débutants 65/100
anomalyco/opencode#65384 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
swc-project/swc-ai-issues#1001 ·
-
Add: Da Vinci Asia VietnamOuvertecheck:passed streams:add
Difficulté 1/5 Moins d'une heure Accessibilité débutants 62/100
Les mainteneurs répondent en général sous 1 jour
-
CLI OAuth login fails behind an authenticating proxy: GET /api/v1/user omits Proxy-AuthorizationOuverte
Difficulté 1/5 Moins d'une heure Accessibilité débutants 85/100
lightdash/lightdash#33086 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
-
assessment bug course exercise programming
Difficulté 2/5 1-3 heures Accessibilité débutants 64/100
Les mainteneurs répondent en général sous 1 jour