Feedback wanted: Intuitive scoring for just-in-time sets

Ouverte
#1,791 4 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 4 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
15/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
À l'abandon
Stack technique
perl
Domaine
backend

Piste de recherche

The proposal concerns the jitar_problem_adjusted_status routine in lib/WeBWorK/Utils.pm, where child-problem weights are summed into $childScore. Read that routine and the just-in-time set grading logic first, then decide how a new scoring mode would sit beside the current one. Done would mean a maintainer-agreed design, since the thread has no decision and the issue has been open about four years.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Problem

The current grading algorithm for just-in-time problem sets is rather unintuitive in my opinion, since for child problems it abuses the meaning of the value field to store some factor which - when considering all child problems which count towards the parent - results in a weight. Also, the points for a child problem shown to the student do not correspond to the actually achievable points if I'm not mistaken.

Solution

It would be better in my opinion if the value field retained its meaning (maximum points to reach for the child problem). The relevant jitar_problem_adjusted_status routine in /lib/WeBWorK/Utils.pm could simply proceed as follows when computing the status of a parent problem:

  1. Gather the weighted sum of all subproblems (as is currently done and saved in $childScore)
  2. If this weighted sum is greater than the value of the parent, return one as the status (i.e. when the values of all child problems counting towards the parent problem add up to something at least as large as the value of the parent problem, the score is capped)
  3. Otherwise divide the weighted sum by the parent problem's value and return the maximum of the result and the parent problem's current status.

Instead of the capping in step two, one could simply consider the case where child problems can yield more points than the parent when combined as illegal and throw an error when the user tries to import or save such a set, but this would unfortunately break backwards compatibility (although I'm sure that everybody will switch to the new algorithm...).

Advantages

In addition to being much more intuitive for the end user, this would also enable to apply penalties when a student reaches the child problems after not being able to solve the parent. With the current algorithm, I see no alternative to the insertion of a dummy child problem (always counted as false).

Instead of the capping in step two, it would be better to consider the case where child problems can yield more points than the parent when combined as illegal and throw an error when the user tries to import or save such a set. However, this would break backwards compatibility.

Implementation

I intend to add another routine for the adjusted status to Utils.pm and then offer either a checkbox labelled “use alternative jit scoring” or a dropdown “scoring algorithm for jit sets” with the current algorithm as default to keep backwards compatibility.

Before implementing this, I'd be thankful for some feedback, in particular whether this has a chance to be included in the main tree as I don't want to maintain a local fork.

Langage dominant
Perl
Étoiles
164
Forks
167
Merge moyen
6 j 7 h
PR mergées (30 j)
27

Préparer son environnement

  • Fournit un Dockerfile ou un fichier Docker Compose
  • Aucun modèle de pull request
  • Aucun guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de openwebwork/webwork2

Toutes les issues de openwebwork/webwork2

Issues similaires

Plus d'issues Perl

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.